Require an explicit ServiceName annotation for interfaces in Python.

Require an explicit ServiceName annotation for interfaces in Python.

BUG= #498
R=qsr@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/dccf9b1b71d8f3d7419b35c70a27140f57d481a6

[azani, 2015-12-08 16:48:13]

azani@chromium.org changed reviewers:
+ qsr@chromium.org

[azani, 2015-12-08 16:48:14]

ptal

[qsr, 2015-12-09 12:39:50]

That seems too small.

For example look at interface_reflection.py, line 150. self.name will be None.
Same thing line 169

Also look at line 54 of application_impl.py

[azani, 2015-12-09 21:09:11]

Thanks for the feedback. ptal

With this change, I'm slightly modifying the behavior of the bindings. Instead
of the proxy and stub being named based on the fully qualified name of the
interface, they are now named based on just the name of the interface. I don't
think this should be a problem as those names should not be referenced anywhere.
What do you think?

[qsr, 2015-12-10 15:13:39]

On 2015/12/09 21:09:11, azani wrote:
> Thanks for the feedback. ptal
> 
> With this change, I'm slightly modifying the behavior of the bindings. Instead
> of the proxy and stub being named based on the fully qualified name of the
> interface, they are now named based on just the name of the interface. I don't
> think this should be a problem as those names should not be referenced
anywhere.
> What do you think?

That seems perfectly fine.

[qsr, 2015-12-10 15:13:54]

LGTM with nit.

https://codereview.chromium.org/1508613003/diff/40001/mojo/public/python/mojo...
File mojo/public/python/mojo_application/application_impl.py (right):

https://codereview.chromium.org/1508613003/diff/40001/mojo/public/python/mojo...
mojo/public/python/mojo_application/application_impl.py:51: if not
service_class.service_name:
I think service_name should be in the manager class, not on the class itself. We
are trying not to restrict the number of collision that can happen as much as
possible.

[azani, 2015-12-10 23:17:50]

Description was changed from

==========
Require an explicit ServiceName annotation for interfaces in Python.

BUG= #498
==========

to

==========
Require an explicit ServiceName annotation for interfaces in Python.

BUG= #498
R=qsr@chromium.org

Committed:
https://chromium.googlesource.com/external/mojo/+/dccf9b1b71d8f3d7419b35c70a2...
==========

[azani, 2015-12-10 23:17:52]

Committed patchset #6 (id:100001) manually as
dccf9b1b71d8f3d7419b35c70a27140f57d481a6 (presubmit successful).