mojo/public/python/mojo_application/service_provider_impl.py - Issue 1508613003: Require an explicit ServiceName annotation for interfaces in Python.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/python/mojo_application/service_provider_impl.py

Issue 1508613003: Require an explicit ServiceName annotation for interfaces in Python. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/public/python/mojo_application/application_impl.py ('k') | mojo/public/python/mojo_bindings/interface_reflection.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/python/mojo_application/service_provider_impl.py

diff --git a/mojo/public/python/mojo_application/service_provider_impl.py b/mojo/public/python/mojo_application/service_provider_impl.py

index 0166c766d37e5f99655e5a3cf1b07d8d331ea730..761ef5fb1d426bda538d8746b310bae741bc0590 100644

--- a/mojo/public/python/mojo_application/service_provider_impl.py

+++ b/mojo/public/python/mojo_application/service_provider_impl.py

@@ -13,8 +13,13 @@ class ServiceProviderImpl(service_provider_mojom.ServiceProvider):

self._provider = provider

self._name_to_service_connector = {}

- def AddService(self, service_class):

- self._name_to_service_connector[service_class.manager.name] = service_class

+ def AddService(self, service_class, service_name=None):

+ if service_name is None:

+ service_name = service_class.manager.service_name

+ if service_name is None:

+ logging.error("No ServiceName specified for %s." % service_class.__name__)

+ return

+ self._name_to_service_connector[service_name] = service_class

def ConnectToService(self, interface_name, pipe):

if interface_name in self._name_to_service_connector: