mojo/public/python/mojo_bindings/interface_reflection.py - Issue 1508613003: Require an explicit ServiceName annotation for interfaces in Python.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/python/mojo_bindings/interface_reflection.py

Issue 1508613003: Require an explicit ServiceName annotation for interfaces in Python. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/public/python/mojo_application/service_provider_impl.py ('k') | mojo/public/tools/bindings/generators/python_templates/module.py.tmpl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/python/mojo_bindings/interface_reflection.py

diff --git a/mojo/public/python/mojo_bindings/interface_reflection.py b/mojo/public/python/mojo_bindings/interface_reflection.py

index 8ce3882106ba7deb30bd3b0b562365e5fc8bebdb..e504387c7e614cee90fc949eb02be40db7a27934 100644

--- a/mojo/public/python/mojo_bindings/interface_reflection.py

+++ b/mojo/public/python/mojo_bindings/interface_reflection.py

@@ -67,7 +67,7 @@ class MojoInterfaceType(type):

fully_qualified_name = descriptor['fully_qualified_name']

interface_manager = InterfaceManager(

- fully_qualified_name, descriptor['version'], methods)

+ name, descriptor['version'], methods, fully_qualified_name)

dictionary.update({

'manager': None,

'_interface_manager': interface_manager,

@@ -97,10 +97,11 @@ class InterfaceManager(object):

over a pipe.

"""

- def __init__(self, name, version, methods):

+ def __init__(self, name, version, methods, service_name):

self.name = name

self.version = version

self.methods = methods

+ self.service_name = service_name

self.interface_class = None

self._proxy_class = None

self._stub_class = None