Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 1508403002: Revert of roll clang 254049:254793 (Closed)

Created:
5 years ago by engedy
Modified:
5 years ago
Reviewers:
hans, Nico
CC:
chromium-reviews, yunlian, eugenis+clang_chromium.org, glider+clang_chromium.org, dmikurube+clang_chromium.org, ukai+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of roll clang 254049:254793 (patchset #3 id:40001 of https://codereview.chromium.org/1507873002/ ) Reason for revert: Speculative revert to see if this fixes link error on 'Google Chrome Linux x64'. Please see first comment on the revert CL for more info. Original issue's description: > roll clang 254049:254793 > > This switches msan to the new ABI. > > It's also the first roll that used update.py instead of > update.sh to build the packages. > > It also changes package.py to bundle up libstdc++ on linux > unconditionally, and removes the --gcc-toolchain flag from > it (the auto-downloaded gcc should be good enough; > one fewer thing I can get wrong). > > BUG=565541 > > Committed: https://crrev.com/3c862a1dff6cbe5f693ba788cdc71770d408e7b7 > Cr-Commit-Position: refs/heads/master@{#363986} TBR=hans@chromium.org,thakis@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=565541 Committed: https://crrev.com/af4e20d002ee9acc62854db5bd89f2aa14b2d419 Cr-Commit-Position: refs/heads/master@{#364051}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -8 lines) Patch
M build/common.gypi View 1 chunk +4 lines, -0 lines 0 comments Download
M build/config/sanitizers/BUILD.gn View 2 chunks +9 lines, -1 line 0 comments Download
M third_party/instrumented_libraries/binaries/msan-chained-origins-precise.tgz.sha1 View 1 chunk +1 line, -1 line 0 comments Download
M third_party/instrumented_libraries/binaries/msan-chained-origins-trusty.tgz.sha1 View 1 chunk +1 line, -1 line 0 comments Download
M third_party/instrumented_libraries/binaries/msan-no-origins-precise.tgz.sha1 View 1 chunk +1 line, -1 line 0 comments Download
M third_party/instrumented_libraries/binaries/msan-no-origins-trusty.tgz.sha1 View 1 chunk +1 line, -1 line 0 comments Download
M tools/clang/scripts/package.py View 4 chunks +10 lines, -2 lines 0 comments Download
M tools/clang/scripts/update.py View 3 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 9 (1 generated)
engedy
Created Revert of roll clang 254049:254793
5 years ago (2015-12-09 12:57:03 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1508403002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1508403002/1
5 years ago (2015-12-09 12:57:21 UTC) #2
engedy
Bot: https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux%20x64 FAILED: ../../third_party/llvm-build/Release+Asserts/bin/clang++ -pie -Wl,--fatal-warnings -fPIC -Wl,-z,noexecstack -Wl,-z,now -Wl,-z,relro -Wl,-z,defs -B../../third_party/binutils/Linux_x64/Release/bin -fuse-ld=gold -Wl,--icf=all -pthread ...
5 years ago (2015-12-09 12:57:49 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-09 12:58:25 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/af4e20d002ee9acc62854db5bd89f2aa14b2d419 Cr-Commit-Position: refs/heads/master@{#364051}
5 years ago (2015-12-09 12:59:27 UTC) #6
Nico
I can't reproduce the link error on my local "roll clang" branch off #363783. I'll ...
5 years ago (2015-12-09 14:52:51 UTC) #7
Nico
On 2015/12/09 14:52:51, Nico wrote: > I can't reproduce the link error on my local ...
5 years ago (2015-12-09 15:20:11 UTC) #8
Nico
5 years ago (2015-12-09 15:35:23 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1514573002/ by thakis@chromium.org.

The reason for reverting is: Should work with CFI reverted..

Powered by Google App Engine
This is Rietveld 408576698