Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: build/config/sanitizers/BUILD.gn

Issue 1508403002: Revert of roll clang 254049:254793 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/common.gypi ('k') | third_party/instrumented_libraries/binaries/msan-chained-origins-precise.tgz.sha1 » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/sanitizers/BUILD.gn
diff --git a/build/config/sanitizers/BUILD.gn b/build/config/sanitizers/BUILD.gn
index 193f19a60e8592f061feff3ad2d368faed39b881..2adab21f21602e5aa4487540c0889770505e5658 100644
--- a/build/config/sanitizers/BUILD.gn
+++ b/build/config/sanitizers/BUILD.gn
@@ -36,7 +36,12 @@
ldflags += [ "-fsanitize=thread" ]
}
if (is_msan) {
- ldflags += [ "-fsanitize=memory" ]
+ ldflags += [
+ "-fsanitize=memory",
+
+ # TODO(eugenis): Remove when msan migrates to new ABI (crbug.com/560589).
+ "-pie",
+ ]
}
if (is_ubsan) {
ldflags += [ "-fsanitize=undefined" ]
@@ -139,6 +144,9 @@
"-fsanitize=memory",
"-fsanitize-memory-track-origins=$msan_track_origins",
"-fsanitize-blacklist=$msan_blacklist_path",
+
+ # TODO(eugenis): Remove when msan migrates to new ABI (crbug.com/560589).
+ "-fPIC",
]
}
if (is_ubsan) {
« no previous file with comments | « build/common.gypi ('k') | third_party/instrumented_libraries/binaries/msan-chained-origins-precise.tgz.sha1 » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698