Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Issue 1507873002: roll clang 254049:254793 (Closed)

Created:
5 years ago by Nico
Modified:
5 years ago
Reviewers:
hans
CC:
chromium-reviews, yunlian, eugenis+clang_chromium.org, glider+clang_chromium.org, dmikurube+clang_chromium.org, ukai+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

roll clang 254049:254793 This switches msan to the new ABI. It's also the first roll that used update.py instead of update.sh to build the packages. It also changes package.py to bundle up libstdc++ on linux unconditionally, and removes the --gcc-toolchain flag from it (the auto-downloaded gcc should be good enough; one fewer thing I can get wrong). BUG=565541 Committed: https://crrev.com/3c862a1dff6cbe5f693ba788cdc71770d408e7b7 Cr-Commit-Position: refs/heads/master@{#363986}

Patch Set 1 #

Patch Set 2 : package2 #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -34 lines) Patch
M build/common.gypi View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M build/config/sanitizers/BUILD.gn View 1 2 chunks +1 line, -9 lines 0 comments Download
M third_party/instrumented_libraries/binaries/msan-chained-origins-precise.tgz.sha1 View 1 chunk +1 line, -1 line 0 comments Download
M third_party/instrumented_libraries/binaries/msan-chained-origins-trusty.tgz.sha1 View 1 chunk +1 line, -1 line 0 comments Download
M third_party/instrumented_libraries/binaries/msan-no-origins-precise.tgz.sha1 View 1 chunk +1 line, -1 line 0 comments Download
M third_party/instrumented_libraries/binaries/msan-no-origins-trusty.tgz.sha1 View 1 chunk +1 line, -1 line 0 comments Download
M tools/clang/scripts/package.py View 1 4 chunks +2 lines, -10 lines 0 comments Download
M tools/clang/scripts/update.py View 3 chunks +1 line, -7 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Nico
5 years ago (2015-12-09 01:03:32 UTC) #4
hans
I see the msan trybot looks happy so far too :-) lgtm
5 years ago (2015-12-09 01:08:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1507873002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1507873002/40001
5 years ago (2015-12-09 03:03:51 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years ago (2015-12-09 05:04:58 UTC) #9
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/3c862a1dff6cbe5f693ba788cdc71770d408e7b7 Cr-Commit-Position: refs/heads/master@{#363986}
5 years ago (2015-12-09 05:06:42 UTC) #11
engedy
5 years ago (2015-12-09 12:57:02 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1508403002/ by engedy@chromium.org.

The reason for reverting is: Speculative revert to see if this fixes link error
on 'Google Chrome Linux x64'. Please see first comment on the revert CL for more
info..

Powered by Google App Engine
This is Rietveld 408576698