Add DMB instruction to the ARM integrated assembler.

Add DMB instruction to the ARM integrated assembler.

Note: There are no updates to the Dart source files, because Dart
doesn't implement this instruction (data memory barrier).

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4334
R=stichnot@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=d3f94f7ef3e6999a7a31641096b70536af46f3f5

[Karl, 2015-12-08 23:40:45]

Description was changed from

==========
Add DMB instruction to the ARM integrated assembler.

Note: There are no updates to the Dart source files, because Dart
doesn't implement this instruction (data memory barrier).

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4334
==========

to

==========
Add DMB instruction to the ARM integrated assembler.

Note: There are no updates to the Dart source files, because Dart
doesn't implement this instruction (data memory barrier).

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4334
==========

[Karl, 2015-12-08 23:40:45]

kschimpf@google.com changed reviewers:
+ jpp@chromium.org, sehr@chromium.org, stichnot@chromium.org

[Jim Stichnoth, 2015-12-09 01:42:03]

lgtm

https://codereview.chromium.org/1507873004/diff/1/src/IceAssemblerARM32.h
File src/IceAssemblerARM32.h (right):

https://codereview.chromium.org/1507873004/diff/1/src/IceAssemblerARM32.h#new...
src/IceAssemblerARM32.h:215: void dmb(IValueT Option); // Option 4 bit value.
What is option 4?

(Maybe you mean "Option is a 4-bit value." ?)

[Karl, 2015-12-09 15:35:07]

Description was changed from

==========
Add DMB instruction to the ARM integrated assembler.

Note: There are no updates to the Dart source files, because Dart
doesn't implement this instruction (data memory barrier).

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4334
==========

to

==========
Add DMB instruction to the ARM integrated assembler.

Note: There are no updates to the Dart source files, because Dart
doesn't implement this instruction (data memory barrier).

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4334
R=stichnot@chromium.org

Committed:
https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a...
==========

[Karl, 2015-12-09 15:35:08]

Committed patchset #2 (id:20001) manually as
d3f94f7ef3e6999a7a31641096b70536af46f3f5 (presubmit successful).

[Karl, 2015-12-09 15:35:18]

https://codereview.chromium.org/1507873004/diff/1/src/IceAssemblerARM32.h
File src/IceAssemblerARM32.h (right):

https://codereview.chromium.org/1507873004/diff/1/src/IceAssemblerARM32.h#new...
src/IceAssemblerARM32.h:215: void dmb(IValueT Option); // Option 4 bit value.
On 2015/12/09 01:42:03, stichnot wrote:
> What is option 4?
> 
> (Maybe you mean "Option is a 4-bit value." ?)

Done.