Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2070)

Unified Diff: chrome/browser/media/router/media_router.h

Issue 1507743005: [MediaRouter] Renames CloseRoute() to Terminate() and creates DetachRoute() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Forgot a call to DetachRoute! Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media/router/media_router.h
diff --git a/chrome/browser/media/router/media_router.h b/chrome/browser/media/router/media_router.h
index fc9079f0f86be1dbaa08c34476ac236fa85bcd94..e46672dcfb407c1f65ad4d05383b8c194db4d7b0 100644
--- a/chrome/browser/media/router/media_router.h
+++ b/chrome/browser/media/router/media_router.h
@@ -100,8 +100,12 @@ class MediaRouter : public KeyedService {
content::WebContents* web_contents,
const std::vector<MediaRouteResponseCallback>& callbacks) = 0;
- // Closes the media route specified by |route_id|.
- virtual void CloseRoute(const MediaRoute::Id& route_id) = 0;
+ // Terminated the media route specified by |route_id|.
imcheng 2015/12/10 19:50:46 s/Terminated/Terminates
mark a. foltz 2015/12/10 23:46:48 Done
+ virtual void TerminateRoute(const MediaRoute::Id& route_id) = 0;
+
+ // Detach the media route specified by |route_id|. The request might come from
imcheng 2015/12/10 19:50:46 s/Detach/Detaches
mark a. foltz 2015/12/10 23:46:48 Done
+ // the page or from an event like navigation or garbage collection.
+ virtual void DetachRoute(const MediaRoute::Id& route_id) = 0;
// Posts |message| to a MediaSink connected via MediaRoute with |route_id|.
virtual void SendRouteMessage(const MediaRoute::Id& route_id,
@@ -121,11 +125,6 @@ class MediaRouter : public KeyedService {
// Clears the issue with the id |issue_id|.
virtual void ClearIssue(const Issue::Id& issue_id) = 0;
- // Indicates that a presentation session has detached from the underlying
- // MediaRoute |route_id| (due to navigation, garbage collection, etc.)
- virtual void OnPresentationSessionDetached(
- const MediaRoute::Id& route_id) = 0;
-
// Returns whether or not there is currently an active local displayable
// route.
virtual bool HasLocalDisplayRoute() const = 0;

Powered by Google App Engine
This is Rietveld 408576698