[MediaRouter] Renames CloseRoute() to Terminate() and creates DetachRoute()

chrome/browser/media/android/router/media_router_android.cc

Index: chrome/browser/media/android/router/media_router_android.cc
diff --git a/chrome/browser/media/android/router/media_router_android.cc b/chrome/browser/media/android/router/media_router_android.cc
index 10e288989c5bb79977469146b195f6bb5ac00d54..c5d58f842a6397b2ac776569f327994fd4bdf2d1 100644
--- a/chrome/browser/media/android/router/media_router_android.cc
+++ b/chrome/browser/media/android/router/media_router_android.cc
@@ -150,7 +150,7 @@ void MediaRouterAndroid::JoinRoute(
       request_id);
 }
 
-void MediaRouterAndroid::CloseRoute(const MediaRoute::Id& route_id) {
+void MediaRouterAndroid::DetachRoute(const MediaRoute::Id& route_id) {
   JNIEnv* env = base::android::AttachCurrentThread();
   ScopedJavaLocalRef<jstring> jroute_id =
           base::android::ConvertUTF8ToJavaString(env, route_id);
@@ -158,6 +158,10 @@ void MediaRouterAndroid::CloseRoute(const MediaRoute::Id& route_id) {
       env, java_media_router_.obj(), jroute_id.obj());
 }
 
+void MediaRouterAndroid::TerminateRoute(const MediaRoute::Id& route_id) {
+  NOTIMPLEMENTED();

[mlamouri (slow - plz ping), 2015/12/10 15:39:51]

Could you add a TODO for avayvod@ and mlamouri@ linked to bug 540803?

[mark a. foltz, 2015/12/10 23:46:48]

Done.

I think I got the semantics switched here. CloseRoute actually should become
Terminate and DetachRoute is NOT_IMPLEMENTED based on my reading of the Java
code.

Let me know if I'm still wrong.

[imcheng, 2015/12/11 00:15:16]

I thought it already has detachRoute. The logic in OnPresentationSessionDetached
should be moved to DetachRoute, and then OnPresentationSessionDetached should be
removed from here and .h file.

+}
+
 void MediaRouterAndroid::SendRouteMessage(
     const MediaRoute::Id& route_id,
     const std::string& message,