Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(617)

Unified Diff: chrome/browser/media/router/media_router.mojom

Issue 1507743005: [MediaRouter] Renames CloseRoute() to Terminate() and creates DetachRoute() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Forgot a call to DetachRoute! Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media/router/media_router.mojom
diff --git a/chrome/browser/media/router/media_router.mojom b/chrome/browser/media/router/media_router.mojom
index 060ad71b1f69f853c6ea283ef8df092b930838a8..a1c69d926bbddc869f9ef4824a419f01d388ac78 100644
--- a/chrome/browser/media/router/media_router.mojom
+++ b/chrome/browser/media/router/media_router.mojom
@@ -143,8 +143,8 @@ interface MediaRouteProvider {
string origin,
int32 tab_id) => (MediaRoute? route, string? error_text);
- // Closes the route specified by |route_id|.
- CloseRoute(string route_id);
+ // Termintes the route specified by |route_id|.
mlamouri (slow - plz ping) 2015/12/10 15:39:51 nit: "Terminates"
mark a. foltz 2015/12/10 23:46:48 Done
+ TerminateRoute(string route_id);
// Sends |message| via the media route |media_route_id|.
// If the operation was successful, |sent| is true; otherwise it is false.
@@ -183,9 +183,10 @@ interface MediaRouteProvider {
// with an empty list.
StopListeningForRouteMessages(string route_id);
- // Indicates that the presentation session that was connected to route
- // |route_id| is no longer connected to it.
- OnPresentationSessionDetached(string route_id);
+ // Indicates that a PresentationConnection that was connected to route
+ // |route_id| has been closed (via .close(), garbage collection or
+ // navigation).
+ DetachRoute(string route_id);
};
// Interface for a service which observes state changes across media

Powered by Google App Engine
This is Rietveld 408576698