Fix several crashes for ARC app launcher.

Fix several crashes for ARC app launcher.

This fixes two crashes in ARC app launcher in Debug build.

BUG=567503
TEST=Build and launch debug Chrome. Manually drag and drop app-luncher
     items, click on not-ready grayed ARC items. No crashes.
TEST=Extented ArcAppModelBuilderTest.LaunchApps unit_tests to handle
     launch attempts of not-ready ARC app items.

Committed: https://crrev.com/ef62f105accf048e4d624b20e0ec59e9ef6894a1
Cr-Commit-Position: refs/heads/master@{#364031}

[khmel, 2015-12-08 05:41:02]

Description was changed from

==========
Fix several crashes for ARC app launcher.

This fixes two crashes in ARC app launcher in Debug build.

BUG=567503
TEST=Build and launch debug Chrome. Manually drag and drop app-luncher
     items, click on not-ready grayed ARC items. No crashes.
TEST=Extented ArcAppModelBuilderTest.LaunchApps unit_tests to handle
     launch attempts of not-ready ARC app items.
==========

to

==========
Fix several crashes for ARC app launcher.

This fixes two crashes in ARC app launcher in Debug build.

BUG=567503
TEST=Build and launch debug Chrome. Manually drag and drop app-luncher
     items, click on not-ready grayed ARC items. No crashes.
TEST=Extented ArcAppModelBuilderTest.LaunchApps unit_tests to handle
     launch attempts of not-ready ARC app items.
==========

[khmel, 2015-12-08 05:41:02]

khmel@chromium.org changed reviewers:
+ xiyuan@chromium.org

[khmel, 2015-12-08 05:42:51]

Hi Xiyuan,

There is small update for arc app launcher support.

PTAL

https://codereview.chromium.org/1507193002/diff/1/chrome/browser/ui/app_list/...
File chrome/browser/ui/app_list/arc/arc_app_item.cc (right):

https://codereview.chromium.org/1507193002/diff/1/chrome/browser/ui/app_list/...
chrome/browser/ui/app_list/arc/arc_app_item.cc:76: if (!ready()) {
Ready is our internal sate only and Activate may be called for not-ready apps.
Handle this case correctly.

https://codereview.chromium.org/1507193002/diff/1/chrome/browser/ui/app_list/...
File chrome/browser/ui/app_list/model_pref_updater.cc (right):

https://codereview.chromium.org/1507193002/diff/1/chrome/browser/ui/app_list/...
chrome/browser/ui/app_list/model_pref_updater.cc:49: else if
(item->GetItemType() == ArcAppItem::kItemType)
'grep -r "ExtensionAppItem::kItemType" --include=*.cc' shows 2 places where
ExtensionAppItem::kItemType are used without  ArcAppItem::kItemType. One place
is here, second place is here:
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/....


ModelPrefUpdaterTest works with mock item that has extension type only.

So adding new type only here.

[xiyuan, 2015-12-08 17:05:34]

xiyuan@chromium.org changed reviewers:
+ calamity@chromium.org

[xiyuan, 2015-12-08 17:05:35]

+calamity

LGTM

I would like to confirm with calamity@ that we want to use
AppListPrefs::AppListInfo::APP_ITEM in
ModelPrefUpdater::UpdatePrefsFromAppListItem to mark an arc app item. I think it
is okay since we care most the position and hierarchy info but let's hear what
calamity@ has to say.

[calamity, 2015-12-09 02:19:16]

On 2015/12/08 17:05:35, xiyuan wrote:
> +calamity
> 
> LGTM
> 
> I would like to confirm with calamity@ that we want to use
> AppListPrefs::AppListInfo::APP_ITEM in
> ModelPrefUpdater::UpdatePrefsFromAppListItem to mark an arc app item. I think
it
> is okay since we care most the position and hierarchy info but let's hear what
> calamity@ has to say.

Yes, this should be fine. The model constraint is that FOLDERs contain ITEMs.

[khmel1, 2015-12-09 09:06:29]

The CQ bit was checked by khmel@google.com

[commit-bot: I haz the power, 2015-12-09 09:07:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1507193002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1507193002/1

[commit-bot: I haz the power, 2015-12-09 10:19:09]

Description was changed from

==========
Fix several crashes for ARC app launcher.

This fixes two crashes in ARC app launcher in Debug build.

BUG=567503
TEST=Build and launch debug Chrome. Manually drag and drop app-luncher
     items, click on not-ready grayed ARC items. No crashes.
TEST=Extented ArcAppModelBuilderTest.LaunchApps unit_tests to handle
     launch attempts of not-ready ARC app items.
==========

to

==========
Fix several crashes for ARC app launcher.

This fixes two crashes in ARC app launcher in Debug build.

BUG=567503
TEST=Build and launch debug Chrome. Manually drag and drop app-luncher
     items, click on not-ready grayed ARC items. No crashes.
TEST=Extented ArcAppModelBuilderTest.LaunchApps unit_tests to handle
     launch attempts of not-ready ARC app items.
==========

[commit-bot: I haz the power, 2015-12-09 10:19:10]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-12-09 10:19:47]

Description was changed from

==========
Fix several crashes for ARC app launcher.

This fixes two crashes in ARC app launcher in Debug build.

BUG=567503
TEST=Build and launch debug Chrome. Manually drag and drop app-luncher
     items, click on not-ready grayed ARC items. No crashes.
TEST=Extented ArcAppModelBuilderTest.LaunchApps unit_tests to handle
     launch attempts of not-ready ARC app items.
==========

to

==========
Fix several crashes for ARC app launcher.

This fixes two crashes in ARC app launcher in Debug build.

BUG=567503
TEST=Build and launch debug Chrome. Manually drag and drop app-luncher
     items, click on not-ready grayed ARC items. No crashes.
TEST=Extented ArcAppModelBuilderTest.LaunchApps unit_tests to handle
     launch attempts of not-ready ARC app items.

Committed: https://crrev.com/ef62f105accf048e4d624b20e0ec59e9ef6894a1
Cr-Commit-Position: refs/heads/master@{#364031}
==========

[commit-bot: I haz the power, 2015-12-09 10:19:49]

Patchset 1 (id:??) landed as
https://crrev.com/ef62f105accf048e4d624b20e0ec59e9ef6894a1
Cr-Commit-Position: refs/heads/master@{#364031}