Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1665)

Unified Diff: chrome/browser/ui/app_list/arc/arc_app_unittest.cc

Issue 1507193002: Fix several crashes for ARC app launcher. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/app_list/arc/arc_app_unittest.cc
diff --git a/chrome/browser/ui/app_list/arc/arc_app_unittest.cc b/chrome/browser/ui/app_list/arc/arc_app_unittest.cc
index df39fe611cc3fb7f29010d96c36a19a96cde6f79..b43abf54f145d22ebee1152047dce315a11df740 100644
--- a/chrome/browser/ui/app_list/arc/arc_app_unittest.cc
+++ b/chrome/browser/ui/app_list/arc/arc_app_unittest.cc
@@ -290,6 +290,17 @@ TEST_F(ArcAppModelBuilderTest, LaunchApps) {
EXPECT_EQ(true, launch_requests[0]->IsForApp(app_first));
EXPECT_EQ(true, launch_requests[1]->IsForApp(app_last));
EXPECT_EQ(true, launch_requests[2]->IsForApp(app_first));
+
+ // Test an attempt to launch of a not-ready app.
+ bridge_service()->SendRefreshAppList(std::vector<arc::AppInfo>());
+ item_first = FindArcItem(GetAppId(app_first));
+ ASSERT_NE(nullptr, item_first);
+ size_t launch_request_count_before =
+ bridge_service()->launch_requests().size();
+ item_first->Activate(0);
+ // Number of launch requests must not change.
+ EXPECT_EQ(launch_request_count_before,
+ bridge_service()->launch_requests().size());
}
TEST_F(ArcAppModelBuilderTest, RequestIcons) {

Powered by Google App Engine
This is Rietveld 408576698