Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6568)

Unified Diff: chrome/browser/ui/app_list/arc/arc_app_item.cc

Issue 1507193002: Fix several crashes for ARC app launcher. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/app_list/arc/arc_app_item.cc
diff --git a/chrome/browser/ui/app_list/arc/arc_app_item.cc b/chrome/browser/ui/app_list/arc/arc_app_item.cc
index 2e1a312772dc77c5408d562880f36fa72fe8eb8b..225ac4b1397249b1a3cb10013e6d186f089a18a3 100644
--- a/chrome/browser/ui/app_list/arc/arc_app_item.cc
+++ b/chrome/browser/ui/app_list/arc/arc_app_item.cc
@@ -73,7 +73,10 @@ const char* ArcAppItem::GetItemType() const {
}
void ArcAppItem::Activate(int event_flags) {
- DCHECK(ready_);
+ if (!ready()) {
khmel 2015/12/08 05:42:51 Ready is our internal sate only and Activate may b
+ VLOG(2) << "Cannot launch not-ready app:" << id() << ".";
+ return;
+ }
ArcAppListPrefs* prefs = ArcAppListPrefs::Get(context_);
scoped_ptr<ArcAppListPrefs::AppInfo> app_info = prefs->GetApp(id());
« no previous file with comments | « no previous file | chrome/browser/ui/app_list/arc/arc_app_unittest.cc » ('j') | chrome/browser/ui/app_list/model_pref_updater.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698