Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 1506623002: fix combinator contributor (Closed)

Created:
5 years ago by danrubel
Modified:
5 years ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

fix combinator contributor gracefully degrade given partially element information better reporting of exceptions during testing R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/372cb6be58ea3db69416099c55595964daf84847

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -23 lines) Patch
M pkg/analysis_server/lib/src/services/completion/dart/suggestion_builder.dart View 1 chunk +6 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/completion_test.dart View 1 chunk +7 lines, -13 lines 0 comments Download
M pkg/analysis_server/test/domain_completion_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/combinator_contributor_test.dart View 3 chunks +11 lines, -4 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/completion_contributor_util.dart View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
danrubel
5 years ago (2015-12-06 16:23:13 UTC) #2
scheglov
LGTM
5 years ago (2015-12-06 17:34:39 UTC) #3
danrubel
5 years ago (2015-12-06 20:34:23 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
372cb6be58ea3db69416099c55595964daf84847 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698