Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Unified Diff: pkg/analysis_server/lib/src/services/completion/dart/suggestion_builder.dart

Issue 1506623002: fix combinator contributor (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analysis_server/test/completion_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/lib/src/services/completion/dart/suggestion_builder.dart
diff --git a/pkg/analysis_server/lib/src/services/completion/dart/suggestion_builder.dart b/pkg/analysis_server/lib/src/services/completion/dart/suggestion_builder.dart
index a46b96b0208dd776c8724dbeadaebe4e6b7cc4d7..fa0cf959fe6291f38be82ebac8d1ddc971c625b6 100644
--- a/pkg/analysis_server/lib/src/services/completion/dart/suggestion_builder.dart
+++ b/pkg/analysis_server/lib/src/services/completion/dart/suggestion_builder.dart
@@ -52,9 +52,12 @@ CompletionSuggestion createSuggestion(Element element,
suggestion.parameterNames = element.parameters
.map((ParameterElement parameter) => parameter.name)
.toList();
- suggestion.parameterTypes = element.parameters
- .map((ParameterElement parameter) => parameter.type.displayName)
- .toList();
+ suggestion.parameterTypes =
+ element.parameters.map((ParameterElement parameter) {
+ DartType paramType = parameter.type;
+ // Gracefully degrade if type not resolved yet
+ return paramType != null ? paramType.displayName : 'var';
+ }).toList();
suggestion.requiredParameterCount = element.parameters
.where((ParameterElement parameter) =>
parameter.parameterKind == ParameterKind.REQUIRED)
« no previous file with comments | « no previous file | pkg/analysis_server/test/completion_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698