pkg/analysis_server/test/services/completion/dart/combinator_contributor_test.dart - Issue 1506623002: fix combinator contributor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/test/services/completion/dart/combinator_contributor_test.dart

Issue 1506623002: fix combinator contributor (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/test/domain_completion_test.dart ('k') | pkg/analysis_server/test/services/completion/dart/completion_contributor_util.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/test/services/completion/dart/combinator_contributor_test.dart

diff --git a/pkg/analysis_server/test/services/completion/dart/combinator_contributor_test.dart b/pkg/analysis_server/test/services/completion/dart/combinator_contributor_test.dart

index 50999b069ddb0fa62c040a6dde475ea33a3aee16..be250e7241d8180e6d09cb72cfe8daa06d94f59c 100644

--- a/pkg/analysis_server/test/services/completion/dart/combinator_contributor_test.dart

+++ b/pkg/analysis_server/test/services/completion/dart/combinator_contributor_test.dart

@@ -76,8 +76,8 @@ class CombinatorContributorTest extends DartCompletionContributorTest {

assertSuggestClass('PB',

relevance: DART_RELEVANCE_DEFAULT,

kind: CompletionSuggestionKind.IDENTIFIER);

- assertSuggestTopLevelVar('T1', null, DART_RELEVANCE_DEFAULT,

- CompletionSuggestionKind.IDENTIFIER);

+ assertSuggestTopLevelVar('T1', null,

+ kind: CompletionSuggestionKind.IDENTIFIER);

assertSuggestFunction('F1', 'PB',

kind: CompletionSuggestionKind.IDENTIFIER);

assertNotSuggested('C');

@@ -127,8 +127,8 @@ class CombinatorContributorTest extends DartCompletionContributorTest {

assertSuggestClass('PB',

relevance: DART_RELEVANCE_DEFAULT,

kind: CompletionSuggestionKind.IDENTIFIER);

- assertSuggestTopLevelVar('T1', null, DART_RELEVANCE_DEFAULT,

- CompletionSuggestionKind.IDENTIFIER);

+ assertSuggestTopLevelVar('T1', null,

+ kind: CompletionSuggestionKind.IDENTIFIER);

assertSuggestFunction('F1', 'PB',

kind: CompletionSuggestionKind.IDENTIFIER);

assertSuggestClass('Clz',

@@ -141,4 +141,11 @@ class CombinatorContributorTest extends DartCompletionContributorTest {

assertNotSuggested('X');

assertNotSuggested('Object');

}

+ test_Combinator_show_PI() async {

+ addTestSource('import "dart:math" show ^;');

+ await computeSuggestions();

+ assertSuggestTopLevelVar('PI', 'double',

+ kind: CompletionSuggestionKind.IDENTIFIER);

+ }

}