Remove DocumentTab

Remove DocumentTab

Moves the creation and initialization logic to DocumentActivity and
removes DocumentTab.

BUG=546182
Committed: https://crrev.com/c087b8315ace270f8d6e018de41ce9d8e7955c2e
Cr-Commit-Position: refs/heads/master@{#364369}

[Yusuf, 2015-12-09 17:56:12]

The CQ bit was checked by yusufo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-09 17:56:40]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1506273004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1506273004/1

[commit-bot: I haz the power, 2015-12-09 18:16:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-09 18:16:19]

Dry run: Try jobs failed on following builders:
  android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)

[Yusuf, 2015-12-09 18:21:06]

The CQ bit was checked by yusufo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-09 18:21:50]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1506273004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1506273004/20001

[commit-bot: I haz the power, 2015-12-09 18:36:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-09 18:36:38]

Dry run: Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_compile_dbg on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_compile...)
  linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_r...)

[Yusuf, 2015-12-09 18:43:25]

The CQ bit was checked by yusufo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-09 18:45:26]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1506273004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1506273004/40001

[commit-bot: I haz the power, 2015-12-09 19:29:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-09 19:29:45]

Dry run: This issue passed the CQ dry run.

[Yusuf, 2015-12-09 19:31:00]

yusufo@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[gone, 2015-12-09 22:19:19]

https://chromiumcodereview.appspot.com/1506273004/diff/40001/chrome/android/j...
File
chrome/android/java/src/org/chromium/chrome/browser/document/DocumentActivity.java
(right):

https://chromiumcodereview.appspot.com/1506273004/diff/40001/chrome/android/j...
chrome/android/java/src/org/chromium/chrome/browser/document/DocumentActivity.java:786:
return TabLaunchType.FROM_EXTERNAL_APP;
feels like there should be another case here for tabs opened in foreground tabs.
 is there an enum for that?

https://chromiumcodereview.appspot.com/1506273004/diff/40001/chrome/android/j...
File chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java (right):

https://chromiumcodereview.appspot.com/1506273004/diff/40001/chrome/android/j...
chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java:1250: * @param
unfreeze TODO(yusufo):
er...

[Yusuf, 2015-12-09 22:29:21]

https://codereview.chromium.org/1506273004/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/document/DocumentActivity.java
(right):

https://codereview.chromium.org/1506273004/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/document/DocumentActivity.java:786:
return TabLaunchType.FROM_EXTERNAL_APP;
On 2015/12/09 22:19:19, dfalcantara wrote:
> feels like there should be another case here for tabs opened in foreground
tabs.
>  is there an enum for that?

As a historical reference, these were the only three we have been using. All
tabs opened in foreground is marked with External app. And yes I think that ends
up marking the NTPs created by that as well.

Should we add that FROM_MENU_OVERVIEW if it is an NTP?

[gone, 2015-12-09 22:37:06]

lgtm

https://codereview.chromium.org/1506273004/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/document/DocumentActivity.java
(right):

https://codereview.chromium.org/1506273004/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/document/DocumentActivity.java:786:
return TabLaunchType.FROM_EXTERNAL_APP;
On 2015/12/09 22:29:21, Yusuf wrote:
> On 2015/12/09 22:19:19, dfalcantara wrote:
> > feels like there should be another case here for tabs opened in foreground
> tabs.
> >  is there an enum for that?
> 
> As a historical reference, these were the only three we have been using. All
> tabs opened in foreground is marked with External app. And yes I think that
ends
> up marking the NTPs created by that as well.
> 
> Should we add that FROM_MENU_OVERVIEW if it is an NTP?

Yeah, any extra granularity would be good, considering that stats will be
completely wrong here.  Can do this in a follow-up CL, if this is strictly-moved
code.

[Yusuf, 2015-12-09 23:02:35]

https://codereview.chromium.org/1506273004/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/document/DocumentActivity.java
(right):

https://codereview.chromium.org/1506273004/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/document/DocumentActivity.java:786:
return TabLaunchType.FROM_EXTERNAL_APP;
On 2015/12/09 22:37:06, dfalcantara wrote:
> On 2015/12/09 22:29:21, Yusuf wrote:
> > On 2015/12/09 22:19:19, dfalcantara wrote:
> > > feels like there should be another case here for tabs opened in foreground
> > tabs.
> > >  is there an enum for that?
> > 
> > As a historical reference, these were the only three we have been using. All
> > tabs opened in foreground is marked with External app. And yes I think that
> ends
> > up marking the NTPs created by that as well.
> > 
> > Should we add that FROM_MENU_OVERVIEW if it is an NTP?
> 
> Yeah, any extra granularity would be good, considering that stats will be
> completely wrong here.  Can do this in a follow-up CL, if this is
strictly-moved
> code.

Done.

https://codereview.chromium.org/1506273004/diff/40001/chrome/android/java/src...
File chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java (right):

https://codereview.chromium.org/1506273004/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java:1250: * @param
unfreeze TODO(yusufo):
On 2015/12/09 22:19:19, dfalcantara wrote:
> er...

Done.

[Yusuf, 2015-12-09 23:03:34]

The CQ bit was checked by yusufo@chromium.org

[Yusuf, 2015-12-09 23:03:35]

The patchset sent to the CQ was uploaded after l-g-t-m from
dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/1506273004/#ps60001
(title: "Added NTP TabLaunchType and nit fixes")

[commit-bot: I haz the power, 2015-12-09 23:09:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1506273004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1506273004/60001

[Yusuf, 2015-12-09 23:26:15]

The CQ bit was unchecked by yusufo@chromium.org

[Yusuf, 2015-12-10 00:49:13]

The CQ bit was checked by yusufo@chromium.org

[Yusuf, 2015-12-10 00:49:13]

The patchset sent to the CQ was uploaded after l-g-t-m from
dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/1506273004/#ps80001
(title: "Fixed unfreeze logic")

[Yusuf, 2015-12-10 00:49:16]

The CQ bit was unchecked by yusufo@chromium.org

[Yusuf, 2015-12-10 00:49:23]

The CQ bit was checked by yusufo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-10 00:51:02]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1506273004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1506273004/80001

[commit-bot: I haz the power, 2015-12-10 04:51:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-10 04:51:02]

Dry run: This issue passed the CQ dry run.

[Yusuf, 2015-12-10 15:43:57]

The CQ bit was checked by yusufo@chromium.org

[commit-bot: I haz the power, 2015-12-10 15:44:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1506273004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1506273004/80001

[commit-bot: I haz the power, 2015-12-10 15:49:32]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-12-10 15:50:33]

Description was changed from

==========
Remove DocumentTab

Moves the creation and initialization logic to DocumentActivity and
removes DocumentTab.

BUG=546182
==========

to

==========
Remove DocumentTab

Moves the creation and initialization logic to DocumentActivity and
removes DocumentTab.

BUG=546182

Committed: https://crrev.com/c087b8315ace270f8d6e018de41ce9d8e7955c2e
Cr-Commit-Position: refs/heads/master@{#364369}
==========

[commit-bot: I haz the power, 2015-12-10 15:50:34]

Patchset 5 (id:??) landed as
https://crrev.com/c087b8315ace270f8d6e018de41ce9d8e7955c2e
Cr-Commit-Position: refs/heads/master@{#364369}