Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3402)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tabmodel/ChromeTabCreator.java

Issue 1506273004: Remove DocumentTab (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed unfreeze logic Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/tabmodel/ChromeTabCreator.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/ChromeTabCreator.java b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/ChromeTabCreator.java
index d4383373ac93dbe47899b1e2af82409038c743ff..0b9382bd45532128c7ee25c8d64b56d7d36f1387 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/ChromeTabCreator.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/ChromeTabCreator.java
@@ -129,7 +129,8 @@ public class ChromeTabCreator extends TabCreatorManager.TabCreator {
== TabModel.INVALID_TAB_INDEX;
tab = Tab.createLiveTab(assignedTabId, mActivity, mIncognito,
mNativeWindow, type, parentId, !openInForeground);
- tab.initialize(webContents, mTabContentManager, delegateFactory, !openInForeground);
+ tab.initialize(
+ webContents, mTabContentManager, delegateFactory, !openInForeground, false);
tab.setParentIntent(parentIntent);
webContents.resumeLoadingCreatedWebContents();
} else if (!openInForeground && SysUtils.isLowEndDevice()) {
@@ -141,7 +142,7 @@ public class ChromeTabCreator extends TabCreatorManager.TabCreator {
// currently no way to pipe that information to this function.
tab = Tab.createTabForLazyLoad(mActivity, mIncognito, mNativeWindow, type,
parentId, loadUrlParams);
- tab.initialize(null, mTabContentManager, delegateFactory, !openInForeground);
+ tab.initialize(null, mTabContentManager, delegateFactory, !openInForeground, false);
mTabSaver.addTabToSaveQueue(tab);
} else {
webContents =
@@ -150,7 +151,8 @@ public class ChromeTabCreator extends TabCreatorManager.TabCreator {
tab = Tab.createLiveTab(Tab.INVALID_TAB_ID, mActivity, mIncognito,
mNativeWindow, type, parentId, !openInForeground);
- tab.initialize(webContents, mTabContentManager, delegateFactory, !openInForeground);
+ tab.initialize(
+ webContents, mTabContentManager, delegateFactory, !openInForeground, false);
tab.loadUrl(loadUrlParams);
}
tab.getTabRedirectHandler().updateIntent(intent);
@@ -183,7 +185,8 @@ public class ChromeTabCreator extends TabCreatorManager.TabCreator {
Tab tab = Tab.createLiveTab(Tab.INVALID_TAB_ID, mActivity, mIncognito,
mNativeWindow, type, parentId, !openInForeground);
tab.initialize(
- webContents, mTabContentManager, new TabDelegateFactory(), !openInForeground);
+ webContents, mTabContentManager,
+ new TabDelegateFactory(), !openInForeground, false);
mTabModel.addTab(tab, position, type);
return true;
}
@@ -276,7 +279,7 @@ public class ChromeTabCreator extends TabCreatorManager.TabCreator {
id, mActivity, state.isIncognito(), mNativeWindow, state.parentId, state);
boolean selectTab = mOrderController.willOpenInForeground(TabLaunchType.FROM_RESTORE,
state.isIncognito());
- tab.initialize(null, mTabContentManager, new TabDelegateFactory(), !selectTab);
+ tab.initialize(null, mTabContentManager, new TabDelegateFactory(), !selectTab, false);
assert state.isIncognito() == mIncognito;
mTabModel.addTab(tab, index, TabLaunchType.FROM_RESTORE);
return tab;

Powered by Google App Engine
This is Rietveld 408576698