Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/webapps/FullScreenActivityTab.java

Issue 1506273004: Remove DocumentTab (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed unfreeze logic Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/webapps/FullScreenActivityTab.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/webapps/FullScreenActivityTab.java b/chrome/android/java/src/org/chromium/chrome/browser/webapps/FullScreenActivityTab.java
index f9194fe47c3dedcf7ded2b34a05e89872ea0eed4..256a8caf8470060728125933b4180e5d5ac4dceb 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/webapps/FullScreenActivityTab.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/webapps/FullScreenActivityTab.java
@@ -17,7 +17,6 @@ import org.chromium.chrome.browser.tab.Tab;
import org.chromium.chrome.browser.tab.TabUma.TabCreationState;
import org.chromium.chrome.browser.tabmodel.TabModel.TabLaunchType;
import org.chromium.content_public.browser.LoadUrlParams;
-import org.chromium.content_public.browser.WebContents;
import org.chromium.content_public.browser.WebContentsObserver;
import org.chromium.ui.base.PageTransition;
import org.chromium.ui.base.WindowAndroid;
@@ -73,8 +72,7 @@ public class FullScreenActivityTab extends Tab {
private void initializeFullScreenActivityTab(TabContentManager tabContentManager,
boolean unfreeze, TopControlsVisibilityDelegate topControlsVisibilityDelegate) {
- initialize(null, tabContentManager, new FullScreenDelegateFactory(), false);
- if (unfreeze) unfreezeContents();
+ initialize(null, tabContentManager, new FullScreenDelegateFactory(), false, unfreeze);
mObserver = createWebContentsObserver();
mTopControlsVisibilityDelegate = topControlsVisibilityDelegate;
}
@@ -105,12 +103,6 @@ public class FullScreenActivityTab extends Tab {
};
}
- @Override
- protected void initContentViewCore(WebContents webContents) {
- super.initContentViewCore(webContents);
- getContentViewCore().setFullscreenRequiredForOrientationLock(false);
- }
-
/**
* Loads the given {@code url}.
* @param url URL to load.

Powered by Google App Engine
This is Rietveld 408576698