Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Side by Side Diff: tools/presubmit.py

Issue 1506233008: [presubmit] Enable readability/nolint linter checking. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/arm64/constants-arm64.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # 2 #
3 # Copyright 2012 the V8 project authors. All rights reserved. 3 # Copyright 2012 the V8 project authors. All rights reserved.
4 # Redistribution and use in source and binary forms, with or without 4 # Redistribution and use in source and binary forms, with or without
5 # modification, are permitted provided that the following conditions are 5 # modification, are permitted provided that the following conditions are
6 # met: 6 # met:
7 # 7 #
8 # * Redistributions of source code must retain the above copyright 8 # * Redistributions of source code must retain the above copyright
9 # notice, this list of conditions and the following disclaimer. 9 # notice, this list of conditions and the following disclaimer.
10 # * Redistributions in binary form must reproduce the above 10 # * Redistributions in binary form must reproduce the above
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
55 # build/include_what_you_use: Started giving false positives for variables 55 # build/include_what_you_use: Started giving false positives for variables
56 # named "string" and "map" assuming that you needed to include STL headers. 56 # named "string" and "map" assuming that you needed to include STL headers.
57 # TODO(bmeurer): Fix and re-enable readability/check 57 # TODO(bmeurer): Fix and re-enable readability/check
58 58
59 LINT_RULES = """ 59 LINT_RULES = """
60 -build/header_guard 60 -build/header_guard
61 +build/include_alpha 61 +build/include_alpha
62 -build/include_what_you_use 62 -build/include_what_you_use
63 -build/namespaces 63 -build/namespaces
64 -readability/check 64 -readability/check
65 -readability/nolint
66 +readability/streams 65 +readability/streams
67 -runtime/references 66 -runtime/references
68 """.split() 67 """.split()
69 68
70 LINT_OUTPUT_PATTERN = re.compile(r'^.+[:(]\d+[:)]|^Done processing') 69 LINT_OUTPUT_PATTERN = re.compile(r'^.+[:(]\d+[:)]|^Done processing')
71 FLAGS_LINE = re.compile("//\s*Flags:.*--([A-z0-9-])+_[A-z0-9].*\n") 70 FLAGS_LINE = re.compile("//\s*Flags:.*--([A-z0-9-])+_[A-z0-9].*\n")
72 71
73 def CppLintWorker(command): 72 def CppLintWorker(command):
74 try: 73 try:
75 process = subprocess.Popen(command, stderr=subprocess.PIPE) 74 process = subprocess.Popen(command, stderr=subprocess.PIPE)
(...skipping 436 matching lines...) Expand 10 before | Expand all | Expand 10 after
512 success &= CheckExternalReferenceRegistration(workspace) 511 success &= CheckExternalReferenceRegistration(workspace)
513 success &= CheckStatusFiles(workspace) 512 success &= CheckStatusFiles(workspace)
514 if success: 513 if success:
515 return 0 514 return 0
516 else: 515 else:
517 return 1 516 return 1
518 517
519 518
520 if __name__ == '__main__': 519 if __name__ == '__main__':
521 sys.exit(Main()) 520 sys.exit(Main())
OLDNEW
« no previous file with comments | « src/arm64/constants-arm64.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698