Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 15062004: Don't force layout when sending mouse events. (Closed)

Created:
7 years, 7 months ago by cbiesinger
Modified:
7 years, 7 months ago
Reviewers:
inferno, eseidel, ojan
CC:
blink-reviews, eae+blinkwatch, jochen+watch_chromium.org, jamesr, eseidel
Visibility:
Public.

Description

Don't force layout when sending mouse events. When needed, the sendInputEvent implementation will do the layout, and this way, it is possible to test code that relies on not forcing layout here (e.g. issue 14859016) R=ojan@chromium.org BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=150324

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -10 lines) Patch
M Tools/DumpRenderTree/chromium/TestRunner/src/EventSender.cpp View 4 chunks +0 lines, -10 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
cbiesinger
7 years, 7 months ago (2013-05-14 01:45:17 UTC) #1
cbiesinger
James/Eric/anyone, if you have thoughts on whether this is a good change please comment :) ...
7 years, 7 months ago (2013-05-14 01:47:59 UTC) #2
eseidel
lgtm Yes. This code looks wrong. Thank you for deleting.
7 years, 7 months ago (2013-05-14 01:50:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cbiesinger@chromium.org/15062004/1
7 years, 7 months ago (2013-05-14 01:50:40 UTC) #4
commit-bot: I haz the power
Retried try job too often on mac_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_layout_rel&number=5330
7 years, 7 months ago (2013-05-14 02:58:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cbiesinger@chromium.org/15062004/1
7 years, 7 months ago (2013-05-14 16:48:47 UTC) #6
commit-bot: I haz the power
Change committed as 150324
7 years, 7 months ago (2013-05-14 17:20:38 UTC) #7
inferno
This seems to have introduced multiple use after free crashes in RenderLayer. See https://cluster-fuzz.appspot.com/testcase?key=184891861 https://cluster-fuzz.appspot.com/testcase?key=184744994
7 years, 7 months ago (2013-05-15 15:30:07 UTC) #8
cbiesinger
7 years, 7 months ago (2013-05-15 21:26:50 UTC) #9
Message was sent while issue was closed.
On 2013/05/15 15:30:07, inferno wrote:
> This seems to have introduced multiple use after free crashes in RenderLayer.
> See
> https://cluster-fuzz.appspot.com/testcase?key=184891861
> https://cluster-fuzz.appspot.com/testcase?key=184744994

Huh. That's... surprising. Looking.

Powered by Google App Engine
This is Rietveld 408576698