Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2168)

Unified Diff: Tools/DumpRenderTree/chromium/TestRunner/src/EventSender.cpp

Issue 15062004: Don't force layout when sending mouse events. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Tools/DumpRenderTree/chromium/TestRunner/src/EventSender.cpp
diff --git a/Tools/DumpRenderTree/chromium/TestRunner/src/EventSender.cpp b/Tools/DumpRenderTree/chromium/TestRunner/src/EventSender.cpp
index 1a2c7177cf1175b6a33657fbc9cd957f6c5ce640..0686fefd165bc2c2831d5c576691d70cc81dc2fb 100644
--- a/Tools/DumpRenderTree/chromium/TestRunner/src/EventSender.cpp
+++ b/Tools/DumpRenderTree/chromium/TestRunner/src/EventSender.cpp
@@ -424,8 +424,6 @@ void EventSender::mouseDown(const CppArgumentList& arguments, CppVariant* result
if (result) // Could be 0 if invoked asynchronously.
result->setNull();
- webview()->layout();
-
int buttonNumber = getButtonNumberFromSingleArg(arguments);
WEBKIT_ASSERT(buttonNumber != -1);
@@ -446,8 +444,6 @@ void EventSender::mouseUp(const CppArgumentList& arguments, CppVariant* result)
if (result) // Could be 0 if invoked asynchronously.
result->setNull();
- webview()->layout();
-
int buttonNumber = getButtonNumberFromSingleArg(arguments);
WEBKIT_ASSERT(buttonNumber != -1);
@@ -506,7 +502,6 @@ void EventSender::mouseMoveTo(const CppArgumentList& arguments, CppVariant* resu
if (arguments.size() < 2 || !arguments[0].isNumber() || !arguments[1].isNumber())
return;
- webview()->layout();
WebPoint mousePos(arguments[0].toInt32(), arguments[1].toInt32());
@@ -1077,11 +1072,6 @@ void EventSender::handleMouseWheel(const CppArgumentList& arguments, CppVariant*
if (arguments.size() < 2 || !arguments[0].isNumber() || !arguments[1].isNumber())
return;
- // Force a layout here just to make sure every position has been
- // determined before we send events (as well as all the other methods
- // that send an event do).
- webview()->layout();
-
int horizontal = arguments[0].toInt32();
int vertical = arguments[1].toInt32();
int paged = false;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698