components/cronet/url_request_context_config.cc - Issue 1505983003: QUIC - cronet - added idle_connection_timeout_seconds and disable experiments

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/url_request_context_config.cc

Issue 1505983003: QUIC - cronet - added idle_connection_timeout_seconds and disable experiments (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@enable_preconnect_exp

Patch Set: Deleted PreConnect option Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/cronet/android/test/javatests/src/org/chromium/net/QuicTest.java ('k') | components/cronet/url_request_context_config_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/url_request_context_config.cc

diff --git a/components/cronet/url_request_context_config.cc b/components/cronet/url_request_context_config.cc

index 63c25a40670446742bd28d776ce11762b1c4684a..32b845c753a216f2fe293b95af98a21e16945393 100644

--- a/components/cronet/url_request_context_config.cc

+++ b/components/cronet/url_request_context_config.cc

@@ -29,6 +29,8 @@ const char kQuicDelayTcpRace[] = "delay_tcp_race";

const char kQuicMaxNumberOfLossyConnections[] =

"max_number_of_lossy_connections";

const char kQuicPacketLossThreshold[] = "packet_loss_threshold";

+const char kQuicIdleConnectionTimeoutSeconds[] =

+ "idle_connection_timeout_seconds";

// AsyncDNS experiment dictionary name.

const char kAsyncDnsFieldTrialName[] = "AsyncDNS";

@@ -95,6 +97,13 @@ void ParseAndSetExperimentalOptions(

context_builder->set_quic_packet_loss_threshold(

quic_packet_loss_threshold);

}

+ int quic_idle_connection_timeout_seconds = 0;

+ if (quic_args->GetInteger(kQuicIdleConnectionTimeoutSeconds,

+ &quic_idle_connection_timeout_seconds)) {

+ context_builder->set_quic_idle_connection_timeout_seconds(

+ quic_idle_connection_timeout_seconds);

+ }

}

const base::DictionaryValue* async_dns_args = nullptr;