Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 150573014: Rename various methods in webkitpy.layout_test.Port to be public (Closed)

Created:
6 years, 10 months ago by Dirk Pranke
Modified:
6 years, 10 months ago
Reviewers:
scottmg
CC:
blink-reviews
Visibility:
Public.

Description

Rename various methods in webkitpy.layout_test.Port to be public They were misleadingly named w/ leading underscores as if they were private. R=scottmg@chromium.org BUG=30536 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166692

Patch Set 1 #

Total comments: 3

Patch Set 2 : remove port.check_httpd stub call from port_testcase #

Messages

Total messages: 7 (0 generated)
Dirk Pranke
6 years, 10 months ago (2014-02-06 01:00:36 UTC) #1
scottmg
lgtm https://codereview.chromium.org/150573014/diff/1/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py File Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py (right): https://codereview.chromium.org/150573014/diff/1/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py#newcode111 Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py:111: port.check_httpd = lambda: True maybe just delete this? ...
6 years, 10 months ago (2014-02-06 01:11:31 UTC) #2
Dirk Pranke
https://codereview.chromium.org/150573014/diff/1/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py File Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py (right): https://codereview.chromium.org/150573014/diff/1/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py#newcode111 Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py:111: port.check_httpd = lambda: True On 2014/02/06 01:11:32, scottmg wrote: ...
6 years, 10 months ago (2014-02-06 01:32:10 UTC) #3
Dirk Pranke
The CQ bit was checked by dpranke@chromium.org
6 years, 10 months ago (2014-02-07 00:08:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpranke@chromium.org/150573014/70001
6 years, 10 months ago (2014-02-07 00:08:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpranke@chromium.org/150573014/70001
6 years, 10 months ago (2014-02-07 02:10:00 UTC) #6
commit-bot: I haz the power
6 years, 10 months ago (2014-02-07 08:32:18 UTC) #7
Message was sent while issue was closed. 
Change committed as 166692

Powered by Google App Engine
This is Rietveld 408576698