Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Side by Side Diff: Tools/Scripts/webkitpy/layout_tests/port/linux.py

Issue 150573014: Rename various methods in webkitpy.layout_test.Port to be public (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: remove port.check_httpd stub call from port_testcase Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 # Copyright (C) 2010 Google Inc. All rights reserved. 1 # Copyright (C) 2010 Google Inc. All rights reserved.
2 # 2 #
3 # Redistribution and use in source and binary forms, with or without 3 # Redistribution and use in source and binary forms, with or without
4 # modification, are permitted provided that the following conditions are 4 # modification, are permitted provided that the following conditions are
5 # met: 5 # met:
6 # 6 #
7 # * Redistributions of source code must retain the above copyright 7 # * Redistributions of source code must retain the above copyright
8 # notice, this list of conditions and the following disclaimer. 8 # notice, this list of conditions and the following disclaimer.
9 # * Redistributions in binary form must reproduce the above 9 # * Redistributions in binary form must reproduce the above
10 # copyright notice, this list of conditions and the following disclaimer 10 # copyright notice, this list of conditions and the following disclaimer
(...skipping 133 matching lines...) Expand 10 before | Expand all | Expand 10 after
144 'platform/linux/fast/text/subpixel', 144 'platform/linux/fast/text/subpixel',
145 ['--enable-webkit-text-subpixel-positioning']) , 145 ['--enable-webkit-text-subpixel-positioning']) ,
146 ]) 146 ])
147 return result 147 return result
148 148
149 # 149 #
150 # PROTECTED METHODS 150 # PROTECTED METHODS
151 # 151 #
152 152
153 def _check_apache_install(self): 153 def _check_apache_install(self):
154 result = self._check_file_exists(self._path_to_apache(), "apache2") 154 result = self._check_file_exists(self.path_to_apache(), "apache2")
155 result = self._check_file_exists(self._path_to_apache_config_file(), "ap ache2 config file") and result 155 result = self._check_file_exists(self.path_to_apache_config_file(), "apa che2 config file") and result
156 if not result: 156 if not result:
157 _log.error(' Please install using: "sudo apt-get install apache2 libapache2-mod-php5"') 157 _log.error(' Please install using: "sudo apt-get install apache2 libapache2-mod-php5"')
158 _log.error('') 158 _log.error('')
159 return result 159 return result
160 160
161 def _check_lighttpd_install(self): 161 def _check_lighttpd_install(self):
162 result = self._check_file_exists( 162 result = self._check_file_exists(
163 self._path_to_lighttpd(), "LigHTTPd executable") 163 self._path_to_lighttpd(), "LigHTTPd executable")
164 result = self._check_file_exists(self._path_to_lighttpd_php(), "PHP CGI executable") and result 164 result = self._check_file_exists(self._path_to_lighttpd_php(), "PHP CGI executable") and result
165 result = self._check_file_exists(self._path_to_lighttpd_modules(), "LigH TTPd modules") and result 165 result = self._check_file_exists(self._path_to_lighttpd_modules(), "LigH TTPd modules") and result
166 if not result: 166 if not result:
167 _log.error(' Please install using: "sudo apt-get install lighttpd php5-cgi"') 167 _log.error(' Please install using: "sudo apt-get install lighttpd php5-cgi"')
168 _log.error('') 168 _log.error('')
169 return result 169 return result
170 170
171 def _wdiff_missing_message(self): 171 def _wdiff_missing_message(self):
172 return 'wdiff is not installed; please install using "sudo apt-get insta ll wdiff"' 172 return 'wdiff is not installed; please install using "sudo apt-get insta ll wdiff"'
173 173
174 def _path_to_apache(self): 174 def path_to_apache(self):
175 # The Apache binary path can vary depending on OS and distribution 175 # The Apache binary path can vary depending on OS and distribution
176 # See http://wiki.apache.org/httpd/DistrosDefaultLayout 176 # See http://wiki.apache.org/httpd/DistrosDefaultLayout
177 for path in ["/usr/sbin/httpd", "/usr/sbin/apache2"]: 177 for path in ["/usr/sbin/httpd", "/usr/sbin/apache2"]:
178 if self._filesystem.exists(path): 178 if self._filesystem.exists(path):
179 return path 179 return path
180 _log.error("Could not find apache. Not installed or unknown path.") 180 _log.error("Could not find apache. Not installed or unknown path.")
181 return None 181 return None
182 182
183 def _path_to_lighttpd(self): 183 def path_to_lighttpd(self):
184 return "/usr/sbin/lighttpd" 184 return "/usr/sbin/lighttpd"
185 185
186 def _path_to_lighttpd_modules(self): 186 def path_to_lighttpd_modules(self):
187 return "/usr/lib/lighttpd" 187 return "/usr/lib/lighttpd"
188 188
189 def _path_to_lighttpd_php(self): 189 def path_to_lighttpd_php(self):
190 return "/usr/bin/php-cgi" 190 return "/usr/bin/php-cgi"
191 191
192 def _path_to_driver(self, configuration=None): 192 def _path_to_driver(self, configuration=None):
193 binary_name = self.driver_name() 193 binary_name = self.driver_name()
194 return self._build_path_with_configuration(configuration, binary_name) 194 return self._build_path_with_configuration(configuration, binary_name)
195 195
196 def _path_to_helper(self): 196 def _path_to_helper(self):
197 return None 197 return None
OLDNEW
« no previous file with comments | « Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py ('k') | Tools/Scripts/webkitpy/layout_tests/port/mac.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698