Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py - Issue 150573014: Rename various methods in webkitpy.layout_test.Port to be public

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py

Issue 150573014: Rename various methods in webkitpy.layout_test.Port to be public (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: remove port.check_httpd stub call from port_testcase Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py

diff --git a/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py b/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py

index 263e50203fcbb36e34d07247eab83ff0ad1b4884..e0e76d701271eebd44f2e8f70a4a8473270b79ef 100644

--- a/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py

+++ b/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py

@@ -332,7 +332,7 @@ class PortTest(unittest.TestCase):

def test_check_httpd_success(self):

port = self.make_port(executive=MockExecutive2())

- port._path_to_apache = lambda: '/usr/sbin/httpd'

+ port.path_to_apache = lambda: '/usr/sbin/httpd'

capture = OutputCapture()

capture.capture_output()

self.assertTrue(port.check_httpd())

@@ -341,7 +341,7 @@ class PortTest(unittest.TestCase):

def test_httpd_returns_error_code(self):

port = self.make_port(executive=MockExecutive2(exit_code=1))

- port._path_to_apache = lambda: '/usr/sbin/httpd'

+ port.path_to_apache = lambda: '/usr/sbin/httpd'

capture = OutputCapture()

capture.capture_output()

self.assertFalse(port.check_httpd())