Use "second" instead of "sec" in TimeRemainingLong()

Use "second" instead of "sec" in TimeRemainingLong()

This makes more sense, also it is consistent with
TimeDurationLong().

At that occasion, fix bad grammar in ui_strings.grd.

Unit testing is provisional and will be adjusted once
https://codereview.chromium.org/139413005/ has landed.

BUG=340113
TEST=full unit test coverage

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=249335

[Thiemo Nagel, 2014-02-05 14:10:14]

Hi Tony, Bartosz,

could you please take a look at this?

(I have no idea what the GRIT whitelist is for -- my changes there are solely
drawn from analogy.)

Thank you,
Thiemo

[bartfab (slow), 2014-02-05 17:48:19]

LGTM

grit_whitelist.txt lists the strings that should be available on iOS. Since
TimeRemainingLong() is meant to be available on iOS, you did the right thing by
whitelisting the strings that it uses.

https://codereview.chromium.org/150573011/diff/1/ui/base/strings/ui_strings.grd
File ui/base/strings/ui_strings.grd (right):

https://codereview.chromium.org/150573011/diff/1/ui/base/strings/ui_strings.g...
ui/base/strings/ui_strings.grd:577: desc="NUMBER_ONE is one or one-like numbers
: 1 (many European and most Indian languages), 1 and 0 (French, Brazilian
Portuguese and Hindi), 1,21,31, .. (Russian, Ukrainian, Croatian, Serbian,
Latvian, Lithuanian), or 1, 101, 201, .. (Slovenian). Do NOT translate this for
CJK, Vietnamese, Turkish and Kannada">
Nit 1: s/one-like numbers/a one-like number/

Nit 2: Spaces after commas are missing.

https://codereview.chromium.org/150573011/diff/1/ui/base/strings/ui_strings.g...
ui/base/strings/ui_strings.grd:603: desc="NUMBER_TWO is two or two-like/dual
numbers :  2 (Arabic and Irish) or  2, 102, 202 ... (Slovenian). For other
languages, do NOT translated.">
Nit 1: s/or  2/or 2/
Nit 2: s/translated/translate/

[tony, 2014-02-05 17:59:11]

LGTM2.

BTW, Jungshik plans on converting our plural handling to be more like google3
(crbug.com/113268).  I think it's fine to continue to translate the 6 cases for
now.

[Thiemo Nagel, 2014-02-05 19:59:55]

On 2014/02/05 17:48:19, bartfab wrote:
> grit_whitelist.txt lists the strings that should be available on iOS. Since
> TimeRemainingLong() is meant to be available on iOS, you did the right thing
by
> whitelisting the strings that it uses.

Thanks!
 
> Nit 1: s/one-like numbers/a one-like number/
> Nit 2: Spaces after commas are missing.
> Nit 1: s/or  2/or 2/
> Nit 2: s/translated/translate/

I had copied&pasted these.  Now the grammar should be fine in all places. :-)

[Thiemo Nagel, 2014-02-05 23:09:50]

The CQ bit was checked by tnagel@chromium.org

[commit-bot: I haz the power, 2014-02-05 23:11:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tnagel@chromium.org/150573011/70001

[commit-bot: I haz the power, 2014-02-06 01:09:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-06 01:09:55]

Retried try job too often on win_rel for step(s) telemetry_perf_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[Thiemo Nagel, 2014-02-06 07:08:13]

The CQ bit was checked by tnagel@chromium.org

[commit-bot: I haz the power, 2014-02-06 07:12:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tnagel@chromium.org/150573011/70001

[jungshik at Google, 2014-02-06 08:13:52]

LGTM

[commit-bot: I haz the power, 2014-02-06 10:31:50]

Change committed as 249335