Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 1505393002: ui: Fix NinePatchPainter to work in physical pixels. (Closed)

Created:
5 years ago by danakj
Modified:
5 years ago
Reviewers:
oshima, sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2526
Target Ref:
refs/pending/branch-heads/2526
Project:
chromium
Visibility:
Public.

Description

ui: Fix NinePatchPainter to work in physical pixels. This fixes NinePatchPainter to do layout in physical pixels after the change to use slimming-paint in the ui compositor. Instead of using the matrix on the canvas (which won't be meaningful for scale), it uses the gfx::Canvas::SaveAndUnscale() method to move into a physical space and do layout there. R=oshima, sky BUG=539496 Review URL: https://codereview.chromium.org/1424983005 Cr-Commit-Position: refs/heads/master@{#356983} (cherry picked from commit 4bfbb34d989ec59f138b3589e956a3947c139ec3) Committed: https://chromium.googlesource.com/chromium/src/+/0a76a7fdc9332b043ec868602f5a47638e381d44

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+223 lines, -151 lines) Patch
M ui/gfx/canvas.h View 3 chunks +6 lines, -10 lines 0 comments Download
M ui/gfx/canvas.cc View 5 chunks +15 lines, -58 lines 0 comments Download
M ui/gfx/nine_image_painter.cc View 3 chunks +54 lines, -67 lines 0 comments Download
M ui/gfx/nine_image_painter_unittest.cc View 4 chunks +148 lines, -16 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
danakj
5 years ago (2015-12-08 21:40:59 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0a76a7fdc9332b043ec868602f5a47638e381d44.

Powered by Google App Engine
This is Rietveld 408576698