Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 1505253002: [proxies] Fix HasProperty and getOwnPropertySymbols (Closed)

Created:
5 years ago by Jakob Kummerow
Modified:
5 years ago
Reviewers:
Camillo Bruni
CC:
neis, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[proxies] Fix HasProperty and getOwnPropertySymbols JSProxy::HasProperty was missing an early "return Nothing<bool>". KeyAccumulator's FilterProxyKeys() didn't handle SKIP_STRINGS correctly. BUG=v8:1543 LOG=n R=cbruni@chromium.org Committed: https://crrev.com/453e1dfa7abb7ab1061db3af8694a1e32d11aa71 Cr-Commit-Position: refs/heads/master@{#32699}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -11 lines) Patch
M src/key-accumulator.cc View 1 chunk +1 line, -6 lines 0 comments Download
M src/objects.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/objects-inl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M test/mjsunit/harmony/proxies-define-property.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/proxies-has.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/proxies-ownkeys.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Jakob Kummerow
Found these by running test262. PTAL.
5 years ago (2015-12-08 13:33:58 UTC) #1
Camillo Bruni
lgtm
5 years ago (2015-12-08 13:44:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1505253002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1505253002/1
5 years ago (2015-12-09 09:12:05 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-09 09:40:40 UTC) #5
commit-bot: I haz the power
5 years ago (2015-12-09 09:41:18 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/453e1dfa7abb7ab1061db3af8694a1e32d11aa71
Cr-Commit-Position: refs/heads/master@{#32699}

Powered by Google App Engine
This is Rietveld 408576698