Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Unified Diff: src/key-accumulator.cc

Issue 1505253002: [proxies] Fix HasProperty and getOwnPropertySymbols (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/objects.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/key-accumulator.cc
diff --git a/src/key-accumulator.cc b/src/key-accumulator.cc
index 468a1f5f28f3fdb47e2af8a41838f5ea8f9ce7c6..9951636963d29d458c80ee4ab946e49f20f0dcd7 100644
--- a/src/key-accumulator.cc
+++ b/src/key-accumulator.cc
@@ -231,12 +231,7 @@ MaybeHandle<FixedArray> FilterProxyKeys(Isolate* isolate, Handle<JSProxy> owner,
int store_position = 0;
for (int i = 0; i < keys->length(); ++i) {
Handle<Name> key(Name::cast(keys->get(i)), isolate);
- if (key->IsSymbol()) {
- if ((filter & SKIP_SYMBOLS) || Handle<Symbol>::cast(key)->is_private()) {
- continue; // Skip this key.
- }
- }
- if (filter & SKIP_STRINGS) continue; // Skip this key.
+ if (key->FilterKey(filter)) continue; // Skip this key.
if (filter & ONLY_ENUMERABLE) {
PropertyDescriptor desc;
bool found =
« no previous file with comments | « no previous file | src/objects.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698