Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(607)

Unified Diff: src/objects-inl.h

Issue 1505253002: [proxies] Fix HasProperty and getOwnPropertySymbols (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/objects.cc ('k') | test/mjsunit/harmony/proxies-define-property.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects-inl.h
diff --git a/src/objects-inl.h b/src/objects-inl.h
index e1e3e48f9b5c1e847a6b650ea1ecdd88118cef8d..b02a2f152d7e1708156b220f283acae816d6caff 100644
--- a/src/objects-inl.h
+++ b/src/objects-inl.h
@@ -292,9 +292,9 @@ bool Object::FilterKey(PropertyFilter filter) {
if (IsSymbol()) {
if (filter & SKIP_SYMBOLS) return true;
if (Symbol::cast(this)->is_private()) return true;
+ } else {
+ if (filter & SKIP_STRINGS) return true;
}
- if ((filter & SKIP_STRINGS) && !IsSymbol()) return true;
-
return false;
}
« no previous file with comments | « src/objects.cc ('k') | test/mjsunit/harmony/proxies-define-property.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698