Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Issue 1505063002: QUIC - FieldTrial parameters not do PreConnect if QUIC can do 0RTT. (Closed)

Created:
5 years ago by ramant (doing other things)
Modified:
5 years ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@disable_preconnect
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

QUIC - FieldTrial parameters not do PreConnect if QUIC can do 0RTT. Added "disable_preconnect_if_0rtt" field trial parameter. When this set to true, it will enable network session's quic_disable_preconnect_if_0rtt param. R=rch@chromium.org Committed: https://crrev.com/a245556b86920c1b4ddb3add551039fcea521559 Cr-Commit-Position: refs/heads/master@{#363971}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -0 lines) Patch
M chrome/browser/io_thread.h View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/io_thread.cc View 3 chunks +11 lines, -0 lines 0 comments Download
M chrome/browser/io_thread_unittest.cc View 2 chunks +10 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 12 (5 generated)
ramant (doing other things)
5 years ago (2015-12-07 23:07:34 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1505063002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1505063002/1
5 years ago (2015-12-08 19:04:09 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/89395)
5 years ago (2015-12-08 19:18:09 UTC) #5
Ryan Hamilton
lgtm
5 years ago (2015-12-08 20:42:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1505063002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1505063002/20001
5 years ago (2015-12-09 02:42:55 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-09 03:59:16 UTC) #10
commit-bot: I haz the power
5 years ago (2015-12-09 04:00:49 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a245556b86920c1b4ddb3add551039fcea521559
Cr-Commit-Position: refs/heads/master@{#363971}

Powered by Google App Engine
This is Rietveld 408576698