Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4028)

Unified Diff: chrome/browser/io_thread_unittest.cc

Issue 1505063002: QUIC - FieldTrial parameters not do PreConnect if QUIC can do 0RTT. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@disable_preconnect
Patch Set: rebase Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/io_thread.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/io_thread_unittest.cc
diff --git a/chrome/browser/io_thread_unittest.cc b/chrome/browser/io_thread_unittest.cc
index ab59e6d786429a2c989ec562b835779f4b7c3b05..cb11582eca8a40b64f15b00c9ad604f69fa8765c 100644
--- a/chrome/browser/io_thread_unittest.cc
+++ b/chrome/browser/io_thread_unittest.cc
@@ -200,6 +200,7 @@ TEST_F(IOThreadTest, EnableQuicFromFieldTrialGroup) {
EXPECT_FALSE(params.quic_close_sessions_on_ip_change);
EXPECT_EQ(net::kIdleConnectionTimeoutSeconds,
params.quic_idle_connection_timeout_seconds);
+ EXPECT_FALSE(params.quic_disable_preconnect_if_0rtt);
EXPECT_FALSE(IOThread::ShouldEnableQuicForDataReductionProxy());
}
@@ -305,6 +306,15 @@ TEST_F(IOThreadTest, QuicIdleConnectionTimeoutSecondsFieldTrialParams) {
EXPECT_EQ(300, params.quic_idle_connection_timeout_seconds);
}
+TEST_F(IOThreadTest, QuicDisablePreConnectIfZeroRtt) {
+ field_trial_group_ = "Enabled";
+ field_trial_params_["disable_preconnect_if_0rtt"] = "true";
+ ConfigureQuicGlobals();
+ net::HttpNetworkSession::Params params;
+ InitializeNetworkSessionParams(&params);
+ EXPECT_TRUE(params.quic_disable_preconnect_if_0rtt);
+}
+
TEST_F(IOThreadTest, PacketLengthFromFieldTrialParams) {
field_trial_group_ = "Enabled";
field_trial_params_["max_packet_length"] = "1450";
« no previous file with comments | « chrome/browser/io_thread.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698