Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Issue 1504923008: DevTools: [SASS] implement AST differ. (Closed)

Created:
5 years ago by lushnikov
Modified:
5 years ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@sass-module-2
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: [SASS] implement AST differ. The patch implements WI.SASSSupport.diffModels method, which computes diff of two AST models. The current implementation doesn't handle rule diff, i.e. adding and removing rules, or modification of rule selectors. BUG=527993 R=pfeldman Committed: https://crrev.com/7df97a0f55fea2e954b4eee19e7944c563f9d036 Cr-Commit-Position: refs/heads/master@{#364463}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+446 lines, -3 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sass/sass-test.js View 1 chunk +61 lines, -2 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector/sass/test-ast-diff-1.html View 1 chunk +121 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector/sass/test-ast-diff-1-expected.txt View 1 chunk +93 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/diff/Diff.js View 1 chunk +44 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sass/SASSSupport.js View 1 chunk +122 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 7 (2 generated)
lushnikov
ptal
5 years ago (2015-12-10 08:00:55 UTC) #1
pfeldman
lgtm
5 years ago (2015-12-10 19:18:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1504923008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1504923008/1
5 years ago (2015-12-10 19:20:53 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-10 20:41:03 UTC) #5
commit-bot: I haz the power
5 years ago (2015-12-10 20:42:54 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7df97a0f55fea2e954b4eee19e7944c563f9d036
Cr-Commit-Position: refs/heads/master@{#364463}

Powered by Google App Engine
This is Rietveld 408576698