Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sass/SASSSupport.js

Issue 1504923008: DevTools: [SASS] implement AST differ. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@sass-module-2
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/diff/Diff.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/sass/SASSSupport.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sass/SASSSupport.js b/third_party/WebKit/Source/devtools/front_end/sass/SASSSupport.js
index 9e4ea5c974d5200668877e101ad08d19c048d2c9..2a8fb596697f6ee0cbe8f6cf94b086230f7284f6 100644
--- a/third_party/WebKit/Source/devtools/front_end/sass/SASSSupport.js
+++ b/third_party/WebKit/Source/devtools/front_end/sass/SASSSupport.js
@@ -370,3 +370,125 @@ WebInspector.SASSSupport.AST.prototype = {
__proto__: WebInspector.SASSSupport.Node.prototype
}
+
+/** @enum {string} */
+WebInspector.SASSSupport.PropertyChangeType = {
+ PropertyAdded: "PropertyAdded",
+ PropertyRemoved: "PropertyRemoved",
+ PropertyToggled: "PropertyToggled",
+ ValueChanged: "ValueChanged",
+ NameChanged: "NameChanged"
+}
+
+/**
+ * @constructor
+ * @param {!WebInspector.SASSSupport.PropertyChangeType} type
+ * @param {!WebInspector.SASSSupport.Rule} oldRule
+ * @param {!WebInspector.SASSSupport.Rule} newRule
+ * @param {number} oldPropertyIndex
+ * @param {number} newPropertyIndex
+ */
+WebInspector.SASSSupport.PropertyChange = function(type, oldRule, newRule, oldPropertyIndex, newPropertyIndex)
+{
+ this.type = type;
+ this.oldRule = oldRule;
+ this.newRule = newRule;
+ this.oldPropertyIndex = oldPropertyIndex;
+ this.newPropertyIndex = newPropertyIndex;
+}
+
+/**
+ * @constructor
+ * @param {!Map<!WebInspector.SASSSupport.TextNode, !WebInspector.SASSSupport.TextNode>} mapping
+ * @param {!Array<!WebInspector.SASSSupport.PropertyChange>} changes
+ */
+WebInspector.SASSSupport.ASTDiff = function(mapping, changes)
+{
+ this.mapping = mapping;
+ this.changes = changes;
+}
+
+/**
+ * @param {!WebInspector.SASSSupport.AST} oldAST
+ * @param {!WebInspector.SASSSupport.AST} newAST
+ * @return {!WebInspector.SASSSupport.ASTDiff}
+ */
+WebInspector.SASSSupport.diffModels = function(oldAST, newAST)
+{
+ console.assert(oldAST.rules.length === newAST.rules.length, "Not implemented for rule diff.");
+ var T = WebInspector.SASSSupport.PropertyChangeType;
+ var changes = [];
+ /** @type {!Map<!WebInspector.SASSSupport.TextNode, !WebInspector.SASSSupport.TextNode>} */
+ var mapping = new Map();
+ for (var i = 0; i < oldAST.rules.length; ++i) {
+ var oldRule = oldAST.rules[i];
+ var newRule = newAST.rules[i];
+ computeRuleDiff(mapping, oldRule, newRule);
+ }
+ return new WebInspector.SASSSupport.ASTDiff(mapping, changes);
+
+ /**
+ * @param {!WebInspector.SASSSupport.PropertyChangeType} type
+ * @param {!WebInspector.SASSSupport.Rule} oldRule
+ * @param {!WebInspector.SASSSupport.Rule} newRule
+ * @param {number} oldPropertyIndex
+ * @param {number} newPropertyIndex
+ */
+ function addChange(type, oldRule, newRule, oldPropertyIndex, newPropertyIndex)
+ {
+ changes.push(new WebInspector.SASSSupport.PropertyChange(type, oldRule, newRule, oldPropertyIndex, newPropertyIndex));
+ }
+
+ /**
+ * @param {!Map<!WebInspector.SASSSupport.TextNode, !WebInspector.SASSSupport.TextNode>} mapping
+ * @param {!WebInspector.SASSSupport.Rule} oldRule
+ * @param {!WebInspector.SASSSupport.Rule} newRule
+ */
+ function computeRuleDiff(mapping, oldRule, newRule)
+ {
+ var oldLines = [];
+ for (var i = 0; i < oldRule.properties.length; ++i)
+ oldLines.push(oldRule.properties[i].name.text.trim() + ":" + oldRule.properties[i].value.text.trim());
+ var newLines = [];
+ for (var i = 0; i < newRule.properties.length; ++i)
+ newLines.push(newRule.properties[i].name.text.trim() + ":" + newRule.properties[i].value.text.trim());
+ var diff = WebInspector.Diff.lineDiff(oldLines, newLines);
+ diff = WebInspector.Diff.convertToEditDiff(diff);
+
+ var p1 = 0, p2 = 0;
+ for (var i = 0; i < diff.length; ++i) {
+ var token = diff[i];
+ if (token[0] === WebInspector.Diff.Operation.Delete) {
+ for (var j = 0; j < token[1]; ++j)
+ addChange(T.PropertyRemoved, oldRule, newRule, p1++, p2);
+ } else if (token[0] === WebInspector.Diff.Operation.Insert) {
+ for (var j = 0; j < token[1]; ++j)
+ addChange(T.PropertyAdded, oldRule, newRule, p1, p2++);
+ } else {
+ for (var j = 0; j < token[1]; ++j)
+ computePropertyDiff(mapping, oldRule, newRule, p1++, p2++);
+ }
+ }
+ }
+
+ /**
+ * @param {!Map<!WebInspector.SASSSupport.TextNode, !WebInspector.SASSSupport.TextNode>} mapping
+ * @param {!WebInspector.SASSSupport.Rule} oldRule
+ * @param {!WebInspector.SASSSupport.Rule} newRule
+ * @param {number} oldPropertyIndex
+ * @param {number} newPropertyIndex
+ */
+ function computePropertyDiff(mapping, oldRule, newRule, oldPropertyIndex, newPropertyIndex)
+ {
+ var oldProperty = oldRule.properties[oldPropertyIndex];
+ var newProperty = newRule.properties[newPropertyIndex];
+ mapping.set(oldProperty.name, newProperty.name);
+ mapping.set(oldProperty.value, newProperty.value);
+ if (oldProperty.name.text.trim() !== newProperty.name.text.trim())
+ addChange(T.NameChanged, oldRule, newRule, oldPropertyIndex, newPropertyIndex);
+ if (oldProperty.value.text.trim() !== newProperty.value.text.trim())
+ addChange(T.ValueChanged, oldRule, newRule, oldPropertyIndex, newPropertyIndex);
+ if (oldProperty.disabled !== newProperty.disabled)
+ addChange(T.PropertyToggled, oldRule, newRule, oldPropertyIndex, newPropertyIndex);
+ }
+}
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/diff/Diff.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698