Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 1515733002: DevTools: [SASS] implement CSS AST-builder. (Closed)

Created:
5 years ago by lushnikov
Modified:
5 years ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@sass-module
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: [SASS] implement CSS AST-builder. The patch implements WI.SASSSupport.parseCSS method, which wraps WI.CSSParser and converts its output into WI.SASSSupport.AST. BUG=527993 R=pfeldman Committed: https://crrev.com/4ad0596afc6617b55e96aa8746f8b488968d966a Cr-Commit-Position: refs/heads/master@{#364323}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : rebaseline test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+437 lines, -18 lines) Patch
M third_party/WebKit/LayoutTests/inspector/elements/styles-1/css-outline-expected.txt View 1 2 11 chunks +13 lines, -11 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sass/sass-test.js View 1 chunk +9 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector/sass/test-ast-css-1.html View 1 1 chunk +60 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector/sass/test-ast-css-1-expected.txt View 1 chunk +97 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector/sass/test-ast-css-2.html View 1 1 chunk +51 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector/sass/test-ast-css-2-expected.txt View 1 1 chunk +44 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector/sass/test-ast-css-3.html View 1 1 chunk +52 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector/sass/test-ast-css-3-expected.txt View 1 1 chunk +47 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sass/SASSSupport.js View 2 chunks +41 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sass/module.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/script_formatter_worker/ScriptFormatterWorker.js View 3 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/CSSParser.js View 1 chunk +19 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (5 generated)
lushnikov
ptal
5 years ago (2015-12-09 22:37:24 UTC) #1
pfeldman
lgtm
5 years ago (2015-12-10 02:35:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1515733002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1515733002/20001
5 years ago (2015-12-10 04:18:28 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/153289)
5 years ago (2015-12-10 05:35:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1515733002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1515733002/40001
5 years ago (2015-12-10 08:11:36 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years ago (2015-12-10 09:20:33 UTC) #10
commit-bot: I haz the power
5 years ago (2015-12-10 09:21:39 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/4ad0596afc6617b55e96aa8746f8b488968d966a
Cr-Commit-Position: refs/heads/master@{#364323}

Powered by Google App Engine
This is Rietveld 408576698