Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1068)

Unified Diff: extensions/common/manifest_handler_helpers.h

Issue 1504453002: Allow arbitrary sizes for extension icons (and bookmark app icons) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/common/manifest_handler_helpers.h
diff --git a/extensions/common/manifest_handler_helpers.h b/extensions/common/manifest_handler_helpers.h
index 4f88174e5392273dd91366c80a843e8573610bf6..b0249c30c96e51e91b95e770b53ee4e3d0795891 100644
--- a/extensions/common/manifest_handler_helpers.h
+++ b/extensions/common/manifest_handler_helpers.h
@@ -24,20 +24,12 @@ namespace manifest_handler_helpers {
bool NormalizeAndValidatePath(std::string* path);
// Loads icon paths defined in dictionary |icons_value| into ExtensionIconSet
-// |icons|. |icons_value| is a dictionary value {icon size -> icon path}. Icons
-// in |icons_value| whose size is not in |icon_sizes| will be ignored.
+// |icons|. |icons_value| is a dictionary value {icon size -> icon path}.
// Returns success. If load fails, |error| will be set.
bool LoadIconsFromDictionary(const base::DictionaryValue* icons_value,
- const int* icon_sizes,
- size_t num_icon_sizes,
ExtensionIconSet* icons,
base::string16* error);
-// As above, but loads all icons in |icons_value|.
-bool LoadAllIconsFromDictionary(const base::DictionaryValue* icons_value,
- ExtensionIconSet* icons,
- base::string16* error);
-
} // namespace manifest_handler_helpers
} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698