Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Side by Side Diff: extensions/common/manifest_handler_helpers.h

Issue 1504453002: Allow arbitrary sizes for extension icons (and bookmark app icons) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef EXTENSIONS_COMMON_MANIFEST_HANDLER_HELPERS_H_ 5 #ifndef EXTENSIONS_COMMON_MANIFEST_HANDLER_HELPERS_H_
6 #define EXTENSIONS_COMMON_MANIFEST_HANDLER_HELPERS_H_ 6 #define EXTENSIONS_COMMON_MANIFEST_HANDLER_HELPERS_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/memory/scoped_ptr.h" 10 #include "base/memory/scoped_ptr.h"
11 #include "base/strings/string16.h" 11 #include "base/strings/string16.h"
12 12
13 class ExtensionIconSet; 13 class ExtensionIconSet;
14 14
15 namespace base { 15 namespace base {
16 class DictionaryValue; 16 class DictionaryValue;
17 } 17 }
18 18
19 namespace extensions { 19 namespace extensions {
20 namespace manifest_handler_helpers { 20 namespace manifest_handler_helpers {
21 21
22 // Strips leading slashes from the file path. Returns true iff the final path is 22 // Strips leading slashes from the file path. Returns true iff the final path is
23 // non empty. 23 // non empty.
24 bool NormalizeAndValidatePath(std::string* path); 24 bool NormalizeAndValidatePath(std::string* path);
25 25
26 // Loads icon paths defined in dictionary |icons_value| into ExtensionIconSet 26 // Loads icon paths defined in dictionary |icons_value| into ExtensionIconSet
27 // |icons|. |icons_value| is a dictionary value {icon size -> icon path}. Icons 27 // |icons|. |icons_value| is a dictionary value {icon size -> icon path}.
28 // in |icons_value| whose size is not in |icon_sizes| will be ignored.
29 // Returns success. If load fails, |error| will be set. 28 // Returns success. If load fails, |error| will be set.
30 bool LoadIconsFromDictionary(const base::DictionaryValue* icons_value, 29 bool LoadIconsFromDictionary(const base::DictionaryValue* icons_value,
31 const int* icon_sizes,
32 size_t num_icon_sizes,
33 ExtensionIconSet* icons, 30 ExtensionIconSet* icons,
34 base::string16* error); 31 base::string16* error);
35 32
36 // As above, but loads all icons in |icons_value|.
37 bool LoadAllIconsFromDictionary(const base::DictionaryValue* icons_value,
38 ExtensionIconSet* icons,
39 base::string16* error);
40
41 } // namespace manifest_handler_helpers 33 } // namespace manifest_handler_helpers
42 } // namespace extensions 34 } // namespace extensions
43 35
44 #endif // EXTENSIONS_COMMON_MANIFEST_HANDLER_HELPERS_H_ 36 #endif // EXTENSIONS_COMMON_MANIFEST_HANDLER_HELPERS_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698