Allow arbitrary sizes for extension icons (and bookmark app icons)

extensions/common/constants.cc

Index: extensions/common/constants.cc
diff --git a/extensions/common/constants.cc b/extensions/common/constants.cc
index 8d079b2e5a864afdf7683c60f82be1d5f236fd64..cfd00c117e3d122b47446a2ee346370dad802811 100644
--- a/extensions/common/constants.cc
+++ b/extensions/common/constants.cc
@@ -61,20 +61,6 @@ const char kMimeTypePng[] = "image/png";
 
 namespace extension_misc {
 
-const int kExtensionIconSizes[] = {EXTENSION_ICON_GIGANTOR,     // 512

[Devlin, 2015/12/07 20:37:19]

Wow, awesome that we don't need this anymore.  The slight downside is that,
without this, I'm not sure I'd know how to find the "general" size for an icon
purpose.  Can you rephrase this enum in the form of a comment and put it on,
say, IconsHandler?

[Evan Stade, 2015/12/07 20:52:48]

Wouldn't you look at the enum definition:
https://code.google.com/p/chromium/codesearch#chromium/src/extensions/common/...

I'm not sure what more info this array provided

[Devlin, 2015/12/07 21:02:39]

Gah.  Mondays.  Ignore.

-                                   EXTENSION_ICON_EXTRA_LARGE,  // 256
-                                   EXTENSION_ICON_LARGE,        // 128
-                                   EXTENSION_ICON_MEDIUM,       // 48
-                                   EXTENSION_ICON_SMALL,        // 32
-                                   EXTENSION_ICON_SMALLISH,     // 24
-                                   EXTENSION_ICON_BITTY,        // 16
-                                   // Additional 2x resources to load.
-                                   2 * EXTENSION_ICON_MEDIUM,  // 96
-                                   2 * EXTENSION_ICON_SMALL    // 64
-};
-
-const size_t kNumExtensionIconSizes = arraysize(kExtensionIconSizes);
-
 const char kPdfExtensionId[] = "mhjfbmdgcfjbbpaeojofohoefgiehjai";
 const char kQuickOfficeComponentExtensionId[] =
     "bpmcpldpdmajfigpchkicefoigmkfalc";