Allow arbitrary sizes for extension icons (and bookmark app icons)

extensions/common/constants.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/common/constants.h"
 
 namespace extensions {
 
 const char kExtensionScheme[] = "chrome-extension";
 const char kExtensionResourceScheme[] = "chrome-extension-resource";
@@ skipping 43 matching lines @@
 const char kRulesStoreName[] = "Extension Rules";
 const char kWebStoreAppId[] = "ahfgeienlihckogmohjhadlkjgocpleb";
 
 const char kMimeTypeJpeg[] = "image/jpeg";
 const char kMimeTypePng[] = "image/png";
 
 }  // namespace extensions
 
 namespace extension_misc {
 
-const int kExtensionIconSizes[] = {EXTENSION_ICON_GIGANTOR,     // 512

[Devlin, 2015/12/07 20:37:19]

Wow, awesome that we don't need this anymore.  The slight downside is that,
without this, I'm not sure I'd know how to find the "general" size for an icon
purpose.  Can you rephrase this enum in the form of a comment and put it on,
say, IconsHandler?

[Evan Stade, 2015/12/07 20:52:48]

Wouldn't you look at the enum definition:
https://code.google.com/p/chromium/codesearch#chromium/src/extensions/common/...

I'm not sure what more info this array provided

[Devlin, 2015/12/07 21:02:39]

Gah.  Mondays.  Ignore.

-                                   EXTENSION_ICON_EXTRA_LARGE,  // 256
-                                   EXTENSION_ICON_LARGE,        // 128
-                                   EXTENSION_ICON_MEDIUM,       // 48
-                                   EXTENSION_ICON_SMALL,        // 32
-                                   EXTENSION_ICON_SMALLISH,     // 24
-                                   EXTENSION_ICON_BITTY,        // 16
-                                   // Additional 2x resources to load.
-                                   2 * EXTENSION_ICON_MEDIUM,  // 96
-                                   2 * EXTENSION_ICON_SMALL    // 64
-};
-
-const size_t kNumExtensionIconSizes = arraysize(kExtensionIconSizes);
-
 const char kPdfExtensionId[] = "mhjfbmdgcfjbbpaeojofohoefgiehjai";
 const char kQuickOfficeComponentExtensionId[] =
     "bpmcpldpdmajfigpchkicefoigmkfalc";
 const char kQuickOfficeInternalExtensionId[] =
     "ehibbfinohgbchlgdbfpikodjaojhccn";
 const char kQuickOfficeExtensionId[] = "gbkeegbaiigmenfmjfclcdgdpimamgkj";
 const char kMimeHandlerPrivateTestExtensionId[] =
     "oickdpebdnfbgkcaoklfcdhjniefkcji";
 
 const char kProdHangoutsExtensionId[] = "nckgahadagoaajjgafhacjanaoiihapd";
 const char* const kHangoutsExtensionIds[6] = {
     kProdHangoutsExtensionId,
     "ljclpkphhpbpinifbeabbhlfddcpfdde",  // Debug.
     "ppleadejekpmccmnpjdimmlfljlkdfej",  // Alpha.
     "eggnbpckecmjlblplehfpjjdhhidfdoj",  // Beta.
     "jfjjdfefebklmdbmenmlehlopoocnoeh",  // Packaged App Debug.
     "knipolnnllmklapflnccelgolnpehhpl"   // Packaged App Prod.
     // Keep in sync with _api_features.json and _manifest_features.json.
 };
 
 }  // namespace extension_misc