Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1503483003: Add chrome_elf and cloud_print to "gn check" (Closed)

Created:
5 years ago by brettw
Modified:
5 years ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, caitkp+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add chrome_elf and cloud_print to "gn check" BUG=460828 Committed: https://crrev.com/a219e929557c7289b528ffa378882d94283ac431 Cr-Commit-Position: refs/heads/master@{#363605}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -8 lines) Patch
M .gn View 1 chunk +2 lines, -6 lines 0 comments Download
M chrome_elf/BUILD.gn View 6 chunks +14 lines, -2 lines 0 comments Download
M cloud_print/service/win/BUILD.gn View 3 chunks +9 lines, -0 lines 0 comments Download
M cloud_print/virtual_driver/win/install/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M cloud_print/virtual_driver/win/port_monitor/BUILD.gn View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (11 generated)
brettw
5 years ago (2015-12-04 22:54:08 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1503483003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1503483003/1
5 years ago (2015-12-04 23:02:10 UTC) #5
Dirk Pranke
lgtm
5 years ago (2015-12-04 23:10:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1503483003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1503483003/1
5 years ago (2015-12-04 23:30:41 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_TIMED_OUT, no build URL) win_chromium_compile_dbg_ng on ...
5 years ago (2015-12-05 01:07:52 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1503483003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1503483003/1
5 years ago (2015-12-05 04:05:04 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_TIMED_OUT, no build URL) win_chromium_compile_dbg_ng on ...
5 years ago (2015-12-05 06:06:40 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1503483003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1503483003/1
5 years ago (2015-12-07 21:00:57 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-07 22:23:49 UTC) #19
commit-bot: I haz the power
5 years ago (2015-12-07 22:25:19 UTC) #21
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/a219e929557c7289b528ffa378882d94283ac431
Cr-Commit-Position: refs/heads/master@{#363605}

Powered by Google App Engine
This is Rietveld 408576698