Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: .gn

Issue 1503483003: Add chrome_elf and cloud_print to "gn check" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome_elf/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: .gn
diff --git a/.gn b/.gn
index eeefe471a98d847853f3f185c7309bae889b3352..6ef6696380bf4c802380f89e4e4b87d98cfba690 100644
--- a/.gn
+++ b/.gn
@@ -28,12 +28,8 @@ check_targets = [
"//chrome/installer/*",
"//chrome/third_party/mozilla_security_manager/*",
"//chromecast/*",
-
- # TODO(brettw): Fix http://crbug.com/460828 and uncomment the following
- # line.
- #"//chrome_elf/*",
- #"//cloud_print/*",
-
+ "//chrome_elf/*",
+ "//cloud_print/*",
"//components/*",
#"//content/*", # A whole lot of errors.
« no previous file with comments | « no previous file | chrome_elf/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698