Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Unified Diff: chrome_elf/BUILD.gn

Issue 1503483003: Add chrome_elf and cloud_print to "gn check" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « .gn ('k') | cloud_print/service/win/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome_elf/BUILD.gn
diff --git a/chrome_elf/BUILD.gn b/chrome_elf/BUILD.gn
index 3afa19b984ec577bd7313832449e5dc3de44e559..d251a106c68ea17d218960e9419b2f2739f1b5a4 100644
--- a/chrome_elf/BUILD.gn
+++ b/chrome_elf/BUILD.gn
@@ -32,6 +32,7 @@ shared_library("chrome_elf") {
":breakpad",
":chrome_elf_manifest",
":chrome_elf_resources",
+ ":common",
"//build/config/sanitizers:deps",
]
configs += [ "//build/config/win:windowed" ]
@@ -54,9 +55,13 @@ source_set("constants") {
}
source_set("common") {
- deps = [
+ public_deps = [
":constants",
]
+ deps = [
+ "//base",
+ "//sandbox",
+ ]
sources = [
"chrome_elf_util.cc",
"chrome_elf_util.h",
@@ -73,6 +78,7 @@ source_set("breakpad") {
]
deps = [
":common",
+ "//base",
"//breakpad:breakpad_handler",
"//chrome/common:version_header",
]
@@ -105,11 +111,14 @@ static_library("blacklist") {
"blacklist/blacklist_interceptions.cc",
"blacklist/blacklist_interceptions.h",
]
+ public_deps = [
+ "//sandbox",
+ ]
deps = [
":breakpad",
+ ":common",
":constants",
"//base",
- "//sandbox:sandbox",
]
}
@@ -124,9 +133,11 @@ test("chrome_elf_unittests") {
deps = [
":blacklist",
":blacklist_test_main_dll",
+ ":common",
"//base",
"//base/test:run_all_unittests",
"//base/test:test_support",
+ "//chrome/common:version_header",
"//sandbox",
"//testing/gtest",
]
@@ -145,6 +156,7 @@ shared_library("blacklist_test_main_dll") {
]
deps = [
":blacklist",
+ ":common",
"//base",
"//build/config/sanitizers:deps",
]
« no previous file with comments | « .gn ('k') | cloud_print/service/win/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698