Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1503203002: Additional clean-up after moving to the new task model; a breaking change needed to allow a bug to … (Closed)

Created:
5 years ago by Brian Wilkerson
Modified:
5 years ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@analyzer-breaking-0.27
Target Ref:
refs/heads/analyzer-breaking-0.27
Visibility:
Public.

Description

Additional clean-up after moving to the new task model; a breaking change needed to allow a bug to be fixed R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/c5f82b8376bc0bf5f1a8c3f6bd90918b84da543d

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -23 lines) Patch
M pkg/analysis_server/benchmark/integration/README.md View 2 chunks +1 line, -4 lines 0 comments Download
M pkg/analyzer/CHANGELOG.md View 3 chunks +11 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/instrumentation/instrumentation.dart View 1 chunk +1 line, -3 lines 0 comments Download
M pkg/analyzer/lib/src/generated/element.dart View 1 chunk +0 lines, -10 lines 0 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 2 chunks +2 lines, -4 lines 2 comments Download

Messages

Total messages: 6 (2 generated)
Brian Wilkerson
5 years ago (2015-12-07 19:57:35 UTC) #2
scheglov
LGTM https://codereview.chromium.org/1503203002/diff/1/pkg/analyzer/lib/src/generated/engine.dart File pkg/analyzer/lib/src/generated/engine.dart (right): https://codereview.chromium.org/1503203002/diff/1/pkg/analyzer/lib/src/generated/engine.dart#newcode1878 pkg/analyzer/lib/src/generated/engine.dart:1878: * TODO(scheglov) add the type, once we have ...
5 years ago (2015-12-07 19:59:11 UTC) #3
Brian Wilkerson
https://codereview.chromium.org/1503203002/diff/1/pkg/analyzer/lib/src/generated/engine.dart File pkg/analyzer/lib/src/generated/engine.dart (right): https://codereview.chromium.org/1503203002/diff/1/pkg/analyzer/lib/src/generated/engine.dart#newcode1878 pkg/analyzer/lib/src/generated/engine.dart:1878: * TODO(scheglov) add the type, once we have only ...
5 years ago (2015-12-07 20:02:26 UTC) #4
Brian Wilkerson
5 years ago (2015-12-07 20:02:46 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
c5f82b8376bc0bf5f1a8c3f6bd90918b84da543d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698