Additional clean-up after moving to the new task model; a breaking change needed to allow a bug to …

pkg/analyzer/lib/src/generated/engine.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library engine;
 
 import 'dart:async';
 import 'dart:collection';
 
 import 'package:analyzer/source/embedder.dart';
@@ skipping 1824 matching lines @@
 }
 
 /**
  * Additional behavior for an analysis context that is required by internal
  * users of the context.
  */
 abstract class InternalAnalysisContext implements AnalysisContext {
   /**
    * A table mapping the sources known to the context to the information known
    * about the source.
-   *
-   * TODO(scheglov) add the type, once we have only one cache.
    */
-  dynamic get analysisCache;
+  AnalysisCache get analysisCache;
 
   /**
    * Allow the client to supply its own content cache.  This will take the
    * place of the content cache created by default, allowing clients to share
    * the content cache between contexts.
    */
   set contentCache(ContentCache value);
 
   /// Get the [EmbedderYamlLocator] for this context.
   EmbedderYamlLocator get embedderYamlLocator;
@@ skipping 11 matching lines @@
 
   /**
    * Return a list of the priority targets being analyzed by this context.
    */
   List<AnalysisTarget> get priorityTargets;
 
   /**
    * The partition that contains analysis results that are not shared with other
    * contexts.
    *
    * TODO(scheglov) add the type, once we have only one cache.

[scheglov, 2015/12/07 19:59:11]

Remove TODO.

[Brian Wilkerson, 2015/12/07 20:02:26]

Done

    */
-  dynamic get privateAnalysisCachePartition;
+  CachePartition get privateAnalysisCachePartition;
 
   /**
    * Sets the [TypeProvider] for this context.
    */
   void set typeProvider(TypeProvider typeProvider);
 
   /**
    * A list of all [WorkManager]s used by this context.
    */
   List<WorkManager> get workManagers;
@@ skipping 508 matching lines @@
    * The data that was created from the source.
    */
   final E data;
 
   /**
    * Initialize a newly created holder to associate the given [data] with the
    * given [modificationTime].
    */
   TimestampedData(this.modificationTime, this.data);
 }