Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Unified Diff: pkg/analyzer/lib/instrumentation/instrumentation.dart

Issue 1503203002: Additional clean-up after moving to the new task model; a breaking change needed to allow a bug to … (Closed) Base URL: https://github.com/dart-lang/sdk.git@analyzer-breaking-0.27
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer/lib/instrumentation/instrumentation.dart
diff --git a/pkg/analyzer/lib/instrumentation/instrumentation.dart b/pkg/analyzer/lib/instrumentation/instrumentation.dart
index 8b36303152faec6ee9b67903a49087012a3cb15a..d23711da02da40a36113c35c99dfe6da054405ff 100644
--- a/pkg/analyzer/lib/instrumentation/instrumentation.dart
+++ b/pkg/analyzer/lib/instrumentation/instrumentation.dart
@@ -104,9 +104,7 @@ class InstrumentationService {
* Log that the given analysis [task] is being performed in the given
* [context].
*/
- void logAnalysisTask(String context, dynamic task) {
- // TODO(brianwilkerson) When the old task model is removed, change the
- // parameter type to AnalysisTask.
+ void logAnalysisTask(String context, AnalysisTask task) {
if (_instrumentationServer != null) {
String description =
(task is AnalysisTask) ? task.description : task.toString();

Powered by Google App Engine
This is Rietveld 408576698