Source/core/rendering/RenderRegion.h - Issue 15027005: [CSS Regions] Elements in a region should be assignable to a named flow

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderRegion.h

Issue 15027005: [CSS Regions] Elements in a region should be assignable to a named flow (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Integrates all feedback. One of the tests causes an ASSERT in ContentShell because of Region Ranges. Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/rendering/RenderRegion.h

diff --git a/Source/core/rendering/RenderRegion.h b/Source/core/rendering/RenderRegion.h

index d06df36c186efd718c5cb70d20591e8b953625e0..9aa4c985173e571226061e2e0daf861a05e12367 100644

--- a/Source/core/rendering/RenderRegion.h

+++ b/Source/core/rendering/RenderRegion.h

@@ -145,6 +145,7 @@ private:

virtual const char* renderName() const { return "RenderRegion"; }

virtual bool canHaveChildren() const OVERRIDE { return false; }

+ virtual bool canDOMChildrenHaveRenderParent() const { return true; }

virtual void insertedIntoTree() OVERRIDE;

virtual void willBeRemovedFromTree() OVERRIDE;

« Source/core/rendering/RenderObject.cpp ('K') | « Source/core/rendering/RenderObject.cpp ('k') | no next file » | no next file with comments »