Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Side by Side Diff: Source/core/rendering/RenderRegion.h

Issue 15027005: [CSS Regions] Elements in a region should be assignable to a named flow (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Integrates all feedback. One of the tests causes an ASSERT in ContentShell because of Region Ranges. Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Adobe Systems Incorporated. All rights reserved. 2 * Copyright (C) 2011 Adobe Systems Incorporated. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above 8 * 1. Redistributions of source code must retain the above
9 * copyright notice, this list of conditions and the following 9 * copyright notice, this list of conditions and the following
10 * disclaimer. 10 * disclaimer.
(...skipping 127 matching lines...) Expand 10 before | Expand all | Expand 10 after
138 LayoutRect overflowRectForFlowThreadPortion(const LayoutRect& flowThreadPort ionRect, bool isFirstPortion, bool isLastPortion) const; 138 LayoutRect overflowRectForFlowThreadPortion(const LayoutRect& flowThreadPort ionRect, bool isFirstPortion, bool isLastPortion) const;
139 void repaintFlowThreadContentRectangle(const LayoutRect& repaintRect, const LayoutRect& flowThreadPortionRect, 139 void repaintFlowThreadContentRectangle(const LayoutRect& repaintRect, const LayoutRect& flowThreadPortionRect,
140 const LayoutRect& flowThreadPortionOverflowRect, const LayoutPoint& regi onLocation) const; 140 const LayoutRect& flowThreadPortionOverflowRect, const LayoutPoint& regi onLocation) const;
141 141
142 virtual bool shouldHaveAutoLogicalHeight() const; 142 virtual bool shouldHaveAutoLogicalHeight() const;
143 143
144 private: 144 private:
145 virtual const char* renderName() const { return "RenderRegion"; } 145 virtual const char* renderName() const { return "RenderRegion"; }
146 146
147 virtual bool canHaveChildren() const OVERRIDE { return false; } 147 virtual bool canHaveChildren() const OVERRIDE { return false; }
148 virtual bool canDOMChildrenHaveRenderParent() const { return true; }
148 149
149 virtual void insertedIntoTree() OVERRIDE; 150 virtual void insertedIntoTree() OVERRIDE;
150 virtual void willBeRemovedFromTree() OVERRIDE; 151 virtual void willBeRemovedFromTree() OVERRIDE;
151 152
152 virtual void layoutBlock(bool relayoutChildren, LayoutUnit pageLogicalHeight = 0) OVERRIDE; 153 virtual void layoutBlock(bool relayoutChildren, LayoutUnit pageLogicalHeight = 0) OVERRIDE;
153 virtual void paintObject(PaintInfo&, const LayoutPoint&) OVERRIDE; 154 virtual void paintObject(PaintInfo&, const LayoutPoint&) OVERRIDE;
154 155
155 virtual void installFlowThread(); 156 virtual void installFlowThread();
156 157
157 PassRefPtr<RenderStyle> computeStyleInRegion(const RenderObject*); 158 PassRefPtr<RenderStyle> computeStyleInRegion(const RenderObject*);
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
211 ASSERT_WITH_SECURITY_IMPLICATION(!object || object->isRenderRegion()); 212 ASSERT_WITH_SECURITY_IMPLICATION(!object || object->isRenderRegion());
212 return static_cast<const RenderRegion*>(object); 213 return static_cast<const RenderRegion*>(object);
213 } 214 }
214 215
215 // This will catch anyone doing an unnecessary cast. 216 // This will catch anyone doing an unnecessary cast.
216 void toRenderRegion(const RenderRegion*); 217 void toRenderRegion(const RenderRegion*);
217 218
218 } // namespace WebCore 219 } // namespace WebCore
219 220
220 #endif // RenderRegion_h 221 #endif // RenderRegion_h
OLDNEW
« Source/core/rendering/RenderObject.cpp ('K') | « Source/core/rendering/RenderObject.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698