Source/core/rendering/RenderObject.cpp - Issue 15027005: [CSS Regions] Elements in a region should be assignable to a named flow

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderObject.cpp

Issue 15027005: [CSS Regions] Elements in a region should be assignable to a named flow (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Integrates all feedback. One of the tests causes an ASSERT in ContentShell because of Region Ranges. Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/rendering/RenderObject.cpp

diff --git a/Source/core/rendering/RenderObject.cpp b/Source/core/rendering/RenderObject.cpp

index fd87b04c83528b1e761e844d77b71da375b5356e..ada88864b98af935fd23318facba379cb5c9f515 100644

--- a/Source/core/rendering/RenderObject.cpp

+++ b/Source/core/rendering/RenderObject.cpp

@@ -3132,6 +3132,11 @@ bool RenderObject::canUpdateSelectionOnRootLineBoxes()

return containingBlock ? !containingBlock->needsLayout() : true;

}

+bool RenderObject::canDOMChildrenHaveRenderParent() const

+ return m_parent ? m_parent->canDOMChildrenHaveRenderParent() : false;

esprehn 2013/06/17 21:41:02 m_parent && m_parent->....; No need for the ternar

// We only create "generated" child renderers like one for first-letter if:

// - the firstLetterBlock can have children in the DOM and

// - the block doesn't have any special assumption on its text children.

« Source/core/dom/NodeRenderingContext.cpp ('K') | « Source/core/rendering/RenderObject.h ('k') | Source/core/rendering/RenderRegion.h » ('j') | no next file with comments »