Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1498003003: Remove kint64max. (Closed)

Created:
5 years ago by Avi (use Gerrit)
Modified:
5 years ago
CC:
chromium-reviews, certificate-transparency-chrome_googlegroups.com, Eran Messeri, vmpstr+watch_chromium.org, miu+watch_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, gavinp+disk_chromium.org, tzik, jam, darin-cc_chromium.org, jkarlin+watch_chromium.org, chromium-apps-reviews_chromium.org, xjz+watch_chromium.org, imcheng+watch_chromium.org, jasonroberts+watch_google.com, nhiroki, feature-media-reviews_chromium.org, michaeln, Lei Zhang, avayvod+watch_chromium.org, kinuko+fileapi, tommycli, isheriff+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove kint64max. BUG=138542, 488550 Committed: https://crrev.com/dd4e61435aa91c89b1efc083c905f4376ef70aa9 Cr-Commit-Position: refs/heads/master@{#363854}

Patch Set 1 #

Patch Set 2 : clever is bad #

Patch Set 3 : fixes #

Patch Set 4 : webm #

Patch Set 5 : win fix #

Total comments: 4

Patch Set 6 : headers #

Total comments: 2

Patch Set 7 : INT64_MAX #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1067 lines, -943 lines) Patch
M base/basictypes.h View 1 chunk +0 lines, -1 line 0 comments Download
M base/sys_info.h View 5 chunks +10 lines, -9 lines 0 comments Download
M base/sys_info.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/sys_info_android.cc View 1 2 6 chunks +22 lines, -20 lines 0 comments Download
M base/sys_info_chromeos.cc View 4 chunks +9 lines, -10 lines 0 comments Download
M base/sys_info_freebsd.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M base/sys_info_internal.h View 1 chunk +0 lines, -2 lines 0 comments Download
M base/sys_info_ios.mm View 4 chunks +8 lines, -8 lines 0 comments Download
M base/sys_info_linux.cc View 4 chunks +10 lines, -10 lines 0 comments Download
M base/sys_info_mac.cc View 4 chunks +9 lines, -9 lines 0 comments Download
M base/sys_info_openbsd.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M base/sys_info_posix.cc View 4 chunks +5 lines, -6 lines 0 comments Download
M base/sys_info_unittest.cc View 4 chunks +12 lines, -12 lines 0 comments Download
M base/sys_info_win.cc View 5 chunks +14 lines, -12 lines 0 comments Download
M chrome/browser/extensions/blob_reader.h View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/extensions/blob_reader.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/internal_auth.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/internal_auth.cc View 14 chunks +29 lines, -28 lines 0 comments Download
M chrome/browser/media_galleries/win/mtp_device_operations_util.cc View 1 2 3 4 5 chunks +10 lines, -7 lines 0 comments Download
M content/browser/appcache/appcache_database.h View 1 2 8 chunks +55 lines, -55 lines 0 comments Download
M content/browser/appcache/appcache_database.cc View 26 chunks +53 lines, -43 lines 0 comments Download
M content/browser/appcache/appcache_database_unittest.cc View 7 chunks +17 lines, -10 lines 0 comments Download
M content/browser/appcache/appcache_storage.h View 14 chunks +49 lines, -46 lines 0 comments Download
M content/browser/appcache/appcache_storage.cc View 4 chunks +10 lines, -8 lines 0 comments Download
M content/browser/appcache/appcache_storage_impl.h View 5 chunks +26 lines, -23 lines 0 comments Download
M content/browser/appcache/appcache_storage_impl.cc View 45 chunks +94 lines, -84 lines 0 comments Download
M content/browser/appcache/appcache_storage_impl_unittest.cc View 8 chunks +13 lines, -12 lines 0 comments Download
M content/browser/fileapi/blob_url_request_job_unittest.cc View 11 chunks +27 lines, -18 lines 0 comments Download
M content/browser/fileapi/file_system_usage_cache_unittest.cc View 9 chunks +21 lines, -18 lines 0 comments Download
M content/browser/fileapi/file_writer_delegate_unittest.cc View 13 chunks +24 lines, -21 lines 0 comments Download
M content/browser/fileapi/obfuscated_file_util_unittest.cc View 28 chunks +40 lines, -36 lines 0 comments Download
M content/browser/quota/mock_quota_manager.h View 3 chunks +6 lines, -4 lines 0 comments Download
M content/browser/quota/mock_quota_manager.cc View 4 chunks +10 lines, -5 lines 0 comments Download
M content/browser/quota/mock_quota_manager_proxy.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/quota/mock_quota_manager_proxy.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M media/blink/websourcebuffer_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M media/blink/websourcebuffer_impl.cc View 2 chunks +4 lines, -1 line 0 comments Download
M media/cast/sender/frame_sender.h View 5 chunks +10 lines, -8 lines 0 comments Download
M media/cast/sender/frame_sender.cc View 10 chunks +21 lines, -16 lines 0 comments Download
M media/filters/chunk_demuxer.h View 2 chunks +4 lines, -2 lines 0 comments Download
M media/filters/chunk_demuxer.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M media/formats/webm/webm_parser.h View 1 2 3 7 chunks +17 lines, -11 lines 0 comments Download
M media/formats/webm/webm_parser.cc View 19 chunks +54 lines, -36 lines 0 comments Download
M media/formats/webm/webm_parser_unittest.cc View 17 chunks +76 lines, -82 lines 0 comments Download
M net/base/backoff_entry.h View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M net/base/backoff_entry.cc View 4 chunks +7 lines, -6 lines 0 comments Download
M net/cert/ct_serialization.cc View 2 chunks +3 lines, -1 line 0 comments Download
M net/disk_cache/simple/simple_entry_impl.h View 1 2 3 4 5 11 chunks +20 lines, -18 lines 0 comments Download
M net/disk_cache/simple/simple_entry_impl.cc View 19 chunks +25 lines, -24 lines 0 comments Download
M net/quic/quic_time.h View 1 9 chunks +22 lines, -21 lines 0 comments Download
M net/quic/quic_time.cc View 3 chunks +9 lines, -9 lines 0 comments Download
M ppapi/proxy/file_io_resource.cc View 2 chunks +5 lines, -1 line 0 comments Download
M storage/browser/fileapi/file_system_operation_impl.h View 5 chunks +8 lines, -5 lines 0 comments Download
M storage/browser/fileapi/file_system_operation_impl.cc View 6 chunks +10 lines, -6 lines 0 comments Download
M storage/browser/fileapi/sandbox_file_stream_writer.h View 5 chunks +12 lines, -11 lines 0 comments Download
M storage/browser/fileapi/sandbox_file_stream_writer.cc View 5 chunks +11 lines, -9 lines 0 comments Download
M storage/browser/quota/quota_manager.h View 18 chunks +49 lines, -51 lines 0 comments Download
M storage/browser/quota/quota_manager.cc View 1 2 3 4 5 6 37 chunks +81 lines, -79 lines 0 comments Download

Dependent Patchsets:

Issue 1502503004 Patch 160001

Messages

Total messages: 45 (18 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1498003003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1498003003/1
5 years ago (2015-12-05 01:15:34 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_dbg/builds/149594) android_chromium_gn_compile_rel on ...
5 years ago (2015-12-05 01:38:19 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1498003003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1498003003/20001
5 years ago (2015-12-05 02:00:07 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_dbg_recipe/builds/153599) android_compile_dbg on ...
5 years ago (2015-12-05 02:22:39 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1498003003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1498003003/40001
5 years ago (2015-12-05 19:10:54 UTC) #10
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_TIMED_OUT, no build URL) ...
5 years ago (2015-12-05 21:12:25 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1498003003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1498003003/60001
5 years ago (2015-12-06 04:56:50 UTC) #14
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/118190) win_chromium_x64_rel_ng on ...
5 years ago (2015-12-06 06:29:38 UTC) #16
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1498003003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1498003003/80001
5 years ago (2015-12-06 18:34:48 UTC) #18
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/151056)
5 years ago (2015-12-06 20:26:47 UTC) #20
Avi (use Gerrit)
mark: base/ sky: chrome/ and content/ dalecurtis: media/ mmenke: net/ raymes: ppapi/ danakj: storage/
5 years ago (2015-12-06 20:40:45 UTC) #22
raymes
ppapi/ lgtm
5 years ago (2015-12-06 23:21:44 UTC) #23
Mark Mentovai
LGTM in base
5 years ago (2015-12-07 15:00:49 UTC) #24
mmenke
net/ LGTM https://codereview.chromium.org/1498003003/diff/80001/net/base/backoff_entry.cc File net/base/backoff_entry.cc (right): https://codereview.chromium.org/1498003003/diff/80001/net/base/backoff_entry.cc#newcode6 net/base/backoff_entry.cc:6: include stdint.h https://codereview.chromium.org/1498003003/diff/80001/net/disk_cache/simple/simple_entry_impl.h File net/disk_cache/simple/simple_entry_impl.h (right): https://codereview.chromium.org/1498003003/diff/80001/net/disk_cache/simple/simple_entry_impl.h#newcode7 ...
5 years ago (2015-12-07 16:18:18 UTC) #25
Avi (use Gerrit)
https://codereview.chromium.org/1498003003/diff/80001/net/base/backoff_entry.cc File net/base/backoff_entry.cc (right): https://codereview.chromium.org/1498003003/diff/80001/net/base/backoff_entry.cc#newcode6 net/base/backoff_entry.cc:6: On 2015/12/07 16:18:18, mmenke wrote: > include stdint.h It's ...
5 years ago (2015-12-07 16:24:29 UTC) #27
Avi (use Gerrit)
https://codereview.chromium.org/1498003003/diff/80001/net/base/backoff_entry.cc File net/base/backoff_entry.cc (right): https://codereview.chromium.org/1498003003/diff/80001/net/base/backoff_entry.cc#newcode6 net/base/backoff_entry.cc:6: On 2015/12/07 16:18:18, mmenke wrote: > include stdint.h It's ...
5 years ago (2015-12-07 16:24:30 UTC) #28
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1498003003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1498003003/100001
5 years ago (2015-12-07 16:25:19 UTC) #29
sky
LGTM
5 years ago (2015-12-07 16:52:37 UTC) #30
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-07 18:21:59 UTC) #32
danakj
storage/ LGTM expect: https://codereview.chromium.org/1498003003/diff/100001/storage/browser/quota/quota_manager.cc File storage/browser/quota/quota_manager.cc (right): https://codereview.chromium.org/1498003003/diff/100001/storage/browser/quota/quota_manager.cc#newcode54 storage/browser/quota/quota_manager.cc:54: const int64_t QuotaManager::kNoLimit = std::numeric_limits<int64_t>::max(); you ...
5 years ago (2015-12-07 18:39:56 UTC) #33
Avi (use Gerrit)
https://codereview.chromium.org/1498003003/diff/100001/storage/browser/quota/quota_manager.cc File storage/browser/quota/quota_manager.cc (right): https://codereview.chromium.org/1498003003/diff/100001/storage/browser/quota/quota_manager.cc#newcode54 storage/browser/quota/quota_manager.cc:54: const int64_t QuotaManager::kNoLimit = std::numeric_limits<int64_t>::max(); On 2015/12/07 18:39:56, danakj ...
5 years ago (2015-12-07 19:46:05 UTC) #35
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1498003003/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1498003003/120001
5 years ago (2015-12-07 19:47:29 UTC) #36
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/140974)
5 years ago (2015-12-07 22:56:24 UTC) #38
DaleCurtis
media/ lgtm
5 years ago (2015-12-08 17:58:40 UTC) #39
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1498003003/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1498003003/120001
5 years ago (2015-12-08 18:06:15 UTC) #42
commit-bot: I haz the power
Committed patchset #7 (id:120001)
5 years ago (2015-12-09 00:44:59 UTC) #43
commit-bot: I haz the power
5 years ago (2015-12-09 00:46:00 UTC) #45
Message was sent while issue was closed. 
Patchset 7 (id:??) landed as
https://crrev.com/dd4e61435aa91c89b1efc083c905f4376ef70aa9
Cr-Commit-Position: refs/heads/master@{#363854}

Powered by Google App Engine
This is Rietveld 408576698